From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbLNY-0001xt-B2 for qemu-devel@nongnu.org; Fri, 06 Jul 2018 03:42:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbLNV-0000RM-7l for qemu-devel@nongnu.org; Fri, 06 Jul 2018 03:42:08 -0400 Date: Fri, 6 Jul 2018 09:42:00 +0200 From: Cornelia Huck Message-ID: <20180706094200.722366d0.cohuck@redhat.com> In-Reply-To: <1530811543-6881-9-git-send-email-jjherne@linux.ibm.com> References: <1530811543-6881-1-git-send-email-jjherne@linux.ibm.com> <1530811543-6881-9-git-send-email-jjherne@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 08/15] s390-bios: Map low core memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jason J. Herne" Cc: qemu-devel@nongnu.org, qemu-s390x@nongnu.org, pasic@linux.ibm.com, bjsdjshi@linux.ibm.com, borntraeger@de.ibm.com On Thu, 5 Jul 2018 13:25:36 -0400 "Jason J. Herne" wrote: > From: "Jason J. Herne" > > Create a new header for basic architecture specific definitions and add a > mapping of low core memory. This mapping will be used by the real dasd boot > process. > > Signed-off-by: Jason J. Herne > Signed-off-by: Jason J. Herne Just a common nit: You may want to change your setup (and update the Author: field of the patches) so you don't get those weird double signoffs. > --- > pc-bios/s390-ccw/main.c | 2 + > pc-bios/s390-ccw/s390-arch.h | 100 +++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 102 insertions(+) > create mode 100644 pc-bios/s390-ccw/s390-arch.h