Re: [Qemu-devel] [PATCH] migration: release MigrationIncomingState in migration_object_finalize

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Dr. David Alan Gilbert (dgilbert@redhat.com) wrote:
> * Lidong Chen (jemmy858585@gmail.com) wrote:
> > Qemu initialize the MigrationIncomingState structure in migration_object_init,
> > but not release it. this patch release it in migration_object_finalize.
> > 
> > Signed-off-by: Lidong Chen <lidongchen@tencent.com>
> 
> Queued

I've had to unqueue this, see below:

> 
> > ---
> >  migration/migration.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/migration/migration.c b/migration/migration.c
> > index 05aec2c..e009a05 100644
> > --- a/migration/migration.c
> > +++ b/migration/migration.c
> > @@ -156,6 +156,13 @@ void migration_object_init(void)
> >  void migration_object_finalize(void)
> >  {
> >      object_unref(OBJECT(current_migration));
> > +
> > +    qemu_sem_destroy(&current_incoming->postcopy_pause_sem_fault);
> > +    qemu_sem_destroy(&current_incoming->postcopy_pause_sem_dst);
> > +    qemu_event_destroy(&current_incoming->main_thread_load_event);
> > +    qemu_mutex_destroy(&current_incoming->rp_mutex);
> > +    g_array_free(current_incoming->postcopy_remote_fds, true);

That array is already free'd in migration_incoming_state_destroy,
so I see reliable glib assert's from this array free.

Dave

> > +    g_free(current_incoming);
> >  }
> >  
> >  /* For outgoing */
> > -- 
> > 1.8.3.1
> > 
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK