qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Cornelia Huck" <cohuck@redhat.com>
Subject: [Qemu-devel] [PATCH for-3.0 0/4] block: revert removal of deprecated options
Date: Fri,  6 Jul 2018 15:06:16 +0200	[thread overview]
Message-ID: <20180706130620.5647-1-cohuck@redhat.com> (raw)

Several -drive options had been marked as deprecated for two releases
and had therefore been removed; unfortunately, libvirt still used at
least two of them (serial number and disk geometry) and the patch
switching away from it is not yet in any released libvirt version.

As agreed, let's revert the removal patches for 3.0; with 3.1, the then
released libvirt versions will be fine. While nobody complained about
the 'addr' option, it is reinstated again as well, but purely to make
all the reverts apply cleanly.

Cornelia Huck (4):
  Revert "block: Remove dead deprecation warning code"
  Revert "block: Remove deprecated -drive option serial"
  Revert "block: Remove deprecated -drive option addr"
  Revert "block: Remove deprecated -drive geometry options"

 block/block-backend.c     |   1 +
 blockdev.c                | 110 ++++++++++++++++++++++++++++++++++++++++++++++
 device-hotplug.c          |   4 ++
 hmp-commands.hx           |   1 +
 hw/block/block.c          |  27 ++++++++++++
 hw/block/nvme.c           |   1 +
 hw/block/virtio-blk.c     |   1 +
 hw/ide/qdev.c             |   1 +
 hw/scsi/scsi-disk.c       |   1 +
 hw/usb/dev-storage.c      |   1 +
 include/hw/block/block.h  |   1 +
 include/sysemu/blockdev.h |   3 ++
 qemu-doc.texi             |  15 +++++++
 qemu-options.hx           |  14 +++++-
 tests/ahci-test.c         |   6 +--
 tests/hd-geo-test.c       |  37 +++++++++++++---
 tests/ide-test.c          |   8 ++--
 17 files changed, 217 insertions(+), 15 deletions(-)

-- 
2.14.4

             reply	other threads:[~2018-07-06 13:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 13:06 Cornelia Huck [this message]
2018-07-06 13:06 ` [Qemu-devel] [PATCH for-3.0 1/4] Revert "block: Remove dead deprecation warning code" Cornelia Huck
2018-07-06 13:06 ` [Qemu-devel] [PATCH for-3.0 2/4] Revert "block: Remove deprecated -drive option serial" Cornelia Huck
2018-07-06 13:06 ` [Qemu-devel] [PATCH for-3.0 3/4] Revert "block: Remove deprecated -drive option addr" Cornelia Huck
2018-07-06 13:06 ` [Qemu-devel] [PATCH for-3.0 4/4] Revert "block: Remove deprecated -drive geometry options" Cornelia Huck
2018-07-10 13:05 ` [Qemu-devel] [PATCH for-3.0 0/4] block: revert removal of deprecated options Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180706130620.5647-1-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).