* [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat
@ 2018-07-09 1:49 Richard Henderson
2019-01-29 18:43 ` Richard Henderson
2019-01-29 19:34 ` Emilio G. Cota
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2018-07-09 1:49 UTC (permalink / raw)
To: qemu-devel
The error indicator for this syscall is -1, not 0.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tests/tcg/multiarch/linux-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
index e80eccc0ce..6d2c02c5c0 100644
--- a/tests/tcg/multiarch/linux-test.c
+++ b/tests/tcg/multiarch/linux-test.c
@@ -503,8 +503,9 @@ static void test_shm(void)
shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777));
ptr = shmat(shmid, NULL, 0);
- if (!ptr)
+ if (ptr == (void *)-1) {
error("shmat");
+ }
memset(ptr, 0, SHM_SIZE);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat
2018-07-09 1:49 [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat Richard Henderson
@ 2019-01-29 18:43 ` Richard Henderson
2019-01-29 19:34 ` Emilio G. Cota
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2019-01-29 18:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée
Ping.
On 7/8/18 6:49 PM, Richard Henderson wrote:
> The error indicator for this syscall is -1, not 0.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tests/tcg/multiarch/linux-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c
> index e80eccc0ce..6d2c02c5c0 100644
> --- a/tests/tcg/multiarch/linux-test.c
> +++ b/tests/tcg/multiarch/linux-test.c
> @@ -503,8 +503,9 @@ static void test_shm(void)
>
> shmid = chk_error(shmget(IPC_PRIVATE, SHM_SIZE, IPC_CREAT | 0777));
> ptr = shmat(shmid, NULL, 0);
> - if (!ptr)
> + if (ptr == (void *)-1) {
> error("shmat");
> + }
>
> memset(ptr, 0, SHM_SIZE);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat
2018-07-09 1:49 [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat Richard Henderson
2019-01-29 18:43 ` Richard Henderson
@ 2019-01-29 19:34 ` Emilio G. Cota
1 sibling, 0 replies; 3+ messages in thread
From: Emilio G. Cota @ 2019-01-29 19:34 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel
On Sun, Jul 08, 2018 at 18:49:53 -0700, Richard Henderson wrote:
> The error indicator for this syscall is -1, not 0.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Emilio G. Cota <cota@braap.org>
E.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-29 19:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-09 1:49 [Qemu-devel] [PATCH] tests/tcg/multiarch/linux-test: Fix error check for shmat Richard Henderson
2019-01-29 18:43 ` Richard Henderson
2019-01-29 19:34 ` Emilio G. Cota
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).