From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcNKF-0005WL-5x for qemu-devel@nongnu.org; Sun, 08 Jul 2018 23:59:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcNKE-00023o-7U for qemu-devel@nongnu.org; Sun, 08 Jul 2018 23:58:59 -0400 Date: Mon, 9 Jul 2018 13:55:22 +1000 From: David Gibson Message-ID: <20180709035522.GC22363@umbus.fritz.box> References: <1530798684-23009-1-git-send-email-linux@roeck-us.net> <20180706011849.GK3450@umbus.fritz.box> <20180707212325.GB1951@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TiqCXmo5T1hvSQQg" Content-Disposition: inline In-Reply-To: <20180707212325.GB1951@roeck-us.net> Subject: Re: [Qemu-devel] [PATCH] sam460ex: Add comment explaining ignored errors from fdt operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Guenter Roeck Cc: Paolo Bonzini , Alexander Graf , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, BALATON Zoltan , Pilippe =?iso-8859-1?Q?Mathieu-Daud=E9?= --TiqCXmo5T1hvSQQg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 07, 2018 at 02:23:25PM -0700, Guenter Roeck wrote: > On Fri, Jul 06, 2018 at 02:41:18PM +0200, Paolo Bonzini wrote: > > On 06/07/2018 03:18, David Gibson wrote: > > >> Ok, but why would it even fail? Maybe it's not this case, but even = if > > >> it's not fatal for the OS, generating different device trees silently > > >> seems like a recipe for Heisenbugs. > > > Yes, quite. Especially since the most likely errors I can see here > > > would actually indicate something has already gone horribly wrong with > > > the device tree construction, so a missing clock-frequency is the > > > least of our troubles. > > >=20 > > > I think using _FDT() here would be a better approach. > >=20 > > Or qemu_fdt_setprop_cell, which is there exactly for this reason. > > Volunteers needed to report it in checkpatch! :) > >=20 > Sure, except it uses different parameters. Why don't you come up with > an implementation that is acceptable to you ? I was asked earlier to add > the comment, which I did, only to now be told that it is insufficient. > This can go on forever. At this point, I'll be happy to send a revert > request. Well, we asked for the comment because we were told that ignoring the error was intentional. When the comment was made, it became clear that wasn't really the case. Really, I should have caught this when I first merged the code, though. The error handling throughout this function is kind of bogus, so I'm about to add my own patch to fix it. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TiqCXmo5T1hvSQQg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAltC3KgACgkQbDjKyiDZ s5IdyRAAqztnmHkbS07tI7pjyMO0b2/44qRqsc8e92tlkrSarDtOiVbbIhildovB xM47ZK6ZTfLRbiC3QlbFMlD8ZYOHHviuDl+INezXOYiEaZKlQ3Y5acRIUTegiZWC hXChnBSF/t1b4uu3gpIVQbEvRCingW0bhTMJV2rZPpIKzFHT7R67xCIXGNQdJ4Dh mQzk4dxE6rBl9A2VlOdLQU3ZdNahaS4T73sz0CKi4wPSGnyq/NF6CzhQfJZkj2qG /3D+mb9V0StRlRxK4BNuZLcVHTP4deqi2TX7LUTCSYztS6bWum3v+VosLC6z03yl t4YMWcDjjfgOmRaTcQ97dJ3alhlLFCEWGJAZQjrQTEJdm7DYyt7UjJv3PdpBlehD zbOxjyB24Iw73b3wowihlZKucEqKi93rOJ9dz1O7OGNFuIc+zl3RdHDvUzuZqTM5 Lu8u8DB1dGVTAr/y8/msbPkENkkSSixRRtnX0lFOIVnNRI7ofTdFTmnrhr8mKBBh rXC3CQC8OUjwWku7AQEGOuzeDpuibP5tjy5HIeZiaVx59HkZZfv96TRHZ+qMDixv KZu59DlZ4JF4hcpvhJUYDs39ez0PyGyrragXifzXPBUEu/1Xv84A+9g7STBN4Zo6 1J6iZQIpYCgAMcpzkdsShdslwqdPLFWRuJsP8EYEVNi7oR22S7E= =sGrc -----END PGP SIGNATURE----- --TiqCXmo5T1hvSQQg--