From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcXBe-0004Av-Jm for qemu-devel@nongnu.org; Mon, 09 Jul 2018 10:30:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcXBa-0007AY-JI for qemu-devel@nongnu.org; Mon, 09 Jul 2018 10:30:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55230) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fcXBa-00078N-B9 for qemu-devel@nongnu.org; Mon, 09 Jul 2018 10:30:42 -0400 Date: Mon, 9 Jul 2018 08:30:38 -0600 From: Alex Williamson Message-ID: <20180709083038.14e63a91@t450s.home> In-Reply-To: References: <20180706163614.23993-1-clg@kaod.org> <20180706111626.0a55d77b@t450s.home> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] vfio/pci: do not set the PCIDevice 'has_rom' attribute List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?Q8OpZHJpYw==?= Le Goater Cc: qemu-devel@nongnu.org, Paolo Bonzini , Peter Xu , "Michael S. Tsirkin" , Marcel Apfelbaum On Mon, 9 Jul 2018 09:04:47 +0200 C=C3=A9dric Le Goater wrote: > On 07/06/2018 07:16 PM, Alex Williamson wrote: > > On Fri, 6 Jul 2018 18:36:14 +0200 > > C=C3=A9dric Le Goater wrote: > > =20 > >> PCI devices needing a ROM allocate an optional MemoryRegion with > >> pci_add_option_rom(). pci_del_option_rom() does the cleanup when the > >> device is destroyed. The only action taken by this routine is to call > >> vmstate_unregister_ram() which clears the id string of the optional > >> ROM RAMBlock and now, also flags the RAMBlock as non-migratable. This > >> was recently added by commit b895de502717 ("migration: discard > >> non-migratable RAMBlocks"), . > >> > >> VFIO devices do their own loading of the PCI option ROM in > >> vfio_pci_size_rom(). The memory region is switched to an I/O region > >> and the PCI attribute 'has_rom' is set but the RAMBlock of the ROM > >> region is not allocated. When the associated PCI device is deleted, > >> pci_del_option_rom() calls vmstate_unregister_ram() which tries to > >> flag a NULL RAMBlock, leading to a SEGV. > >> > >> It seems that 'has_rom' was set to have memory_region_destroy() > >> called, but since commit 469b046ead06 ("memory: remove > >> memory_region_destroy") this is not necessary anymore as the > >> MemoryRegion is freed automagically. > >> > >> Remove the PCIDevice 'has_rom' attribute setting in vfio. > >> > >> Signed-off-by: C=C3=A9dric Le Goater =20 > >=20 > > I think the segfault can be attributed to: > >=20 > > fa53a0e53efd ("memory: drop find_ram_block()") > >=20 > > Prior to that vmstate_unregister_ram() called > > memory_region_get_ram_addr() which would have resulted in > > RAM_ADDR_INVALID. This would have been passed to > > qemu_ram_unset_idstr() which would have used find_ram_block() to lookup > > the RAMBlock, which would be NULL for the invalid address, safely > > avoiding any sort of segfault. =20 >=20 > Yes, but since, commit b895de502717 ("migration: discard non-migratable=20 > RAMBlocks") added :=20 >=20 > void vmstate_unregister_ram(MemoryRegion *mr, DeviceState *dev) > { > qemu_ram_unset_idstr(mr->ram_block); > + qemu_ram_unset_migratable(mr->ram_block); > } >=20 > and qemu_ram_unset_migratable() does not check the block validity. Ok, yes I see that qemu_ram_unset_idstr() does avoid the NULL pointer dereference, so I'll make the fixes tag reference to b895de502717. Thanks, Alex > >> --- > >> > >> Tested on a KVM POWER9 pseries machine and a Mellanox MT27710 > >> Ethernet controller. Performed a couple of plug/unplug, migrated, and > >> did a couple more unplug/plug before powering off. > >> > >> The same tests were done with the previous patches which were > >> addressing the issue at a different level :=20 > >> > >> 1. [PATCH] exec.c: check RAMBlock validity before changing its flag > >> https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg00009.h= tml > >> > >> 2. [PATCH] pci: remove pci_del_option_rom() > >> https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg01651.h= tml > >> > >> Do we still want to remove pci_del_option_rom() ? > >> > >> I caught this bug while deleting a passthrough device from a pseries > >> machine. Here is the stack: > >> =20 > >> #0 qemu_ram_unset_migratable (rb=3D0x0) at /home/legoater/work/qem= u/qemu-xive-3.0.git/exec.c:1994 > >> #1 0x000000010072def0 in vmstate_unregister_ram (mr=3D0x101796af0,= dev=3D) > >> #2 0x0000000100694e5c in pci_del_option_rom (pdev=3D0x101796330) > >> #3 pci_qdev_unrealize (dev=3D, errp=3D) > >> #4 0x00000001005ff910 in device_set_realized (obj=3D0x101796330, v= alue=3D, errp=3D0x0) > >> #5 0x00000001007a487c in property_set_bool (obj=3D0x101796330, v= =3D, name=3D,=20 > >> #6 0x00000001007a7878 in object_property_set (obj=3D0x101796330, v= =3D0x7fff70033110,=20 > >> #7 0x00000001007aaf1c in object_property_set_qobject (obj=3D0x1017= 96330, value=3D,=20 > >> #8 0x00000001007a7b90 in object_property_set_bool (obj=3D0x1017963= 30, value=3D,=20 > >> #9 0x00000001005fcdd8 in device_unparent (obj=3D0x101796330) > >> #10 0x00000001007a6dd0 in object_finalize_child_property (obj=3D, name=3D,=20 > >> #11 0x00000001007a50c0 in object_property_del_child (obj=3D0x10111f= 800, child=3D0x101796330,=20 > >> #12 0x0000000100425cc0 in spapr_phb_remove_pci_device_cb (dev=3D0x1= 01796330) > >> #13 0x0000000100427974 in spapr_drc_release (drc=3D0x1017e2df0) > >> #14 0x0000000100429098 in spapr_drc_detach (drc=3D0x1017e2df0) > >> #15 0x00000001004294e0 in drc_isolate_physical (drc=3D0x1017e2df0) > >> #16 0x000000010042a50c in rtas_set_isolation_state (state=3D0, idx= =3D) > >> =20 > >> hw/vfio/pci.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > >> index a1577dea7fdb..6cbb8fa0549d 100644 > >> --- a/hw/vfio/pci.c > >> +++ b/hw/vfio/pci.c > >> @@ -990,7 +990,6 @@ static void vfio_pci_size_rom(VFIOPCIDevice *vdev) > >> pci_register_bar(&vdev->pdev, PCI_ROM_SLOT, > >> PCI_BASE_ADDRESS_SPACE_MEMORY, &vdev->pdev.rom); > >> =20 > >> - vdev->pdev.has_rom =3D true; > >> vdev->rom_read_failed =3D false; > >> } > >> =20 > > =20 >=20