From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH for 3.0 06/10] docker: gracefully skip check_qemu
Date: Mon, 9 Jul 2018 16:21:13 +0100 [thread overview]
Message-ID: <20180709152117.21585-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180709152117.21585-1-alex.bennee@linaro.org>
Not all our images are able to run the tests. Rather than use features
we can just check for the existence and run-ability of gtester. If the
image has been setup for binfmt_misc it will be able to run anyway.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/docker/common.rc | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index cfc620d554..6df431eb72 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -47,7 +47,13 @@ check_qemu()
else
TEST="$@"
fi
- make $MAKEFLAGS $TEST
+
+ if type gtester > /dev/null 2>&1 && \
+ gtester --version > /dev/null 2>&1; then
+ make $MAKEFLAGS $TEST
+ else
+ echo "No working gtester, skipping make $TEST"
+ fi
}
test_fail()
--
2.17.1
next prev parent reply other threads:[~2018-07-09 15:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:21 [Qemu-devel] [PATCH for 3.0 00/10] various docker fixes Alex Bennée
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 01/10] tests/.gitignore: don't ignore docker tests Alex Bennée
2018-07-10 6:57 ` Fam Zheng
2018-07-10 7:54 ` Alex Bennée
2018-07-10 8:36 ` Fam Zheng
2018-07-10 20:50 ` Philippe Mathieu-Daudé
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 02/10] docker: debian-tricore add git tools Alex Bennée
2018-07-10 20:44 ` Philippe Mathieu-Daudé
2018-07-11 0:07 ` Philippe Mathieu-Daudé
2018-07-12 10:44 ` Alex Bennée
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 03/10] docker: fail more gracefully on docker.py check Alex Bennée
2018-07-10 20:44 ` Philippe Mathieu-Daudé
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 04/10] docker: split configure_qemu from build_qemu Alex Bennée
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 05/10] docker: move make check into check_qemu helper Alex Bennée
2018-07-10 6:59 ` Fam Zheng
2018-07-09 15:21 ` Alex Bennée [this message]
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 07/10] docker: Makefile.include don't include partial images Alex Bennée
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 08/10] docker: disable debian-powerpc-user-cross Alex Bennée
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 09/10] docker: add test-unit runner Alex Bennée
2018-07-10 7:04 ` Fam Zheng
2018-07-12 10:20 ` Alex Bennée
2018-07-09 15:21 ` [Qemu-devel] [PATCH for 3.0 10/10] docker: add expansion for docker-test-FOO to Makefile.include Alex Bennée
2018-07-10 20:49 ` Philippe Mathieu-Daudé
2018-07-10 21:04 ` Alex Bennée
2018-07-11 1:31 ` Fam Zheng
2018-07-12 8:41 ` Alex Bennée
2018-07-10 7:06 ` [Qemu-devel] [PATCH for 3.0 00/10] various docker fixes Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180709152117.21585-7-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=balrogg@gmail.com \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).