qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 2/7] file-posix: Fix fd_open check in raw_co_copy_range_to
Date: Mon,  9 Jul 2018 20:58:23 +0200	[thread overview]
Message-ID: <20180709185828.4248-3-mreitz@redhat.com> (raw)
In-Reply-To: <20180709185828.4248-1-mreitz@redhat.com>

From: Fam Zheng <famz@redhat.com>

One of them is a typo. But update both to be more readable.

Reported-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-id: 20180702025836.20957-3-famz@redhat.com
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block/file-posix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/file-posix.c b/block/file-posix.c
index 98987b80f1..349f77a3af 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -2611,7 +2611,7 @@ static int coroutine_fn raw_co_copy_range_to(BlockDriverState *bs,
     }
 
     src_s = src->bs->opaque;
-    if (fd_open(bs) < 0 || fd_open(bs) < 0) {
+    if (fd_open(src->bs) < 0 || fd_open(dst->bs) < 0) {
         return -EIO;
     }
     return paio_submit_co_full(bs, src_s->fd, src_offset, s->fd, dst_offset,
-- 
2.17.1

  parent reply	other threads:[~2018-07-09 18:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 18:58 [Qemu-devel] [PULL 0/7] Block patches for 3.0-rc0 Max Reitz
2018-07-09 18:58 ` [Qemu-devel] [PULL 1/7] qcow2: Drop unused cluster_data Max Reitz
2018-07-09 18:58 ` Max Reitz [this message]
2018-07-09 18:58 ` [Qemu-devel] [PULL 3/7] qcow2: Drop unreachable break Max Reitz
2018-07-09 18:58 ` [Qemu-devel] [PULL 4/7] raw: Drop superfluous semicolon Max Reitz
2018-07-09 18:58 ` [Qemu-devel] [PULL 5/7] vmdk: Fix possible segfault with non-VMDK backing Max Reitz
2018-07-09 18:58 ` [Qemu-devel] [PULL 6/7] iotests: Add VMDK backing file correlation test Max Reitz
2018-07-09 18:58 ` [Qemu-devel] [PULL 7/7] qcow2: add overlap check for bitmap directory Max Reitz
2018-07-10  9:01 ` [Qemu-devel] [PULL 0/7] Block patches for 3.0-rc0 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180709185828.4248-3-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).