From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, imammedo@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH hack dontapply v2 1/7] acpi: aml: add aml_register()
Date: Tue, 10 Jul 2018 03:01:30 +0300 [thread overview]
Message-ID: <20180710000024.542612-2-mst@redhat.com> (raw)
In-Reply-To: <20180710000024.542612-1-mst@redhat.com>
Based on a patch by Igor Mammedov.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/acpi/aml-build.h | 5 +++++
hw/acpi/aml-build.c | 21 +++++++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index 6c36903c0a..10c7946028 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -346,6 +346,11 @@ Aml *aml_qword_memory(AmlDecode dec, AmlMinFixed min_fixed,
uint64_t len);
Aml *aml_dma(AmlDmaType typ, AmlDmaBusMaster bm, AmlTransferSize sz,
uint8_t channel);
+Aml *aml_register(AmlAddressSpace as,
+ uint8_t bit_width,
+ uint8_t bit_offset,
+ uint64_t address,
+ uint8_t access_size);
Aml *aml_sleep(uint64_t msec);
/* Block AML object primitives */
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index 1e43cd736d..def62b3112 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -874,6 +874,27 @@ Aml *aml_irq_no_flags(uint8_t irq)
return var;
}
+/*
+ * ACPI: 2.0: 16.2.4.16 ASL Macro for Generic Register Descriptor
+ *
+ * access_size comes from:
+ * ACPI 3.0: 17.5.98 Register (Generic Register Resource Descriptor Macro)
+ */
+Aml *aml_register(AmlAddressSpace as,
+ uint8_t bit_width,
+ uint8_t bit_offset,
+ uint64_t address,
+ uint8_t access_size)
+{
+ Aml *var = aml_alloc();
+
+ build_append_byte(var->buf, 0x82); /* Generic Register Descriptor */
+ build_append_byte(var->buf, 0x0C); /* Length, bits[7:0] */
+ build_append_byte(var->buf, 0x0); /* Length, bits[15:8] */
+ build_append_gas(var->buf, as, bit_width, bit_offset, access_size, address);
+ return var;
+}
+
/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLNot */
Aml *aml_lnot(Aml *arg)
{
--
MST
next prev parent reply other threads:[~2018-07-10 0:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 0:01 [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation Michael S. Tsirkin
2018-07-10 0:01 ` Michael S. Tsirkin [this message]
2018-07-10 0:01 ` [Qemu-devel] [PATCH hack dontapply v2 2/7] acpi: generalize aml_package / aml_varpackage Michael S. Tsirkin
2018-07-10 0:01 ` [Qemu-devel] [PATCH hack dontapply v2 3/7] acpi: aml_load/aml_unload Michael S. Tsirkin
2018-07-10 0:01 ` [Qemu-devel] [PATCH hack dontapply v2 4/7] acpi: export acpi_checksum Michael S. Tsirkin
2018-07-10 0:01 ` [Qemu-devel] [PATCH hack dontapply v2 6/7] acpi: aml generation for _CST Michael S. Tsirkin
2018-07-25 12:42 ` Igor Mammedov
2018-07-25 12:54 ` Michael S. Tsirkin
2018-07-25 14:39 ` Igor Mammedov
2018-07-26 17:26 ` Michael S. Tsirkin
2018-07-26 17:43 ` Michael S. Tsirkin
2018-07-10 0:01 ` [Qemu-devel] [PATCH hack dontapply v2 5/7] acpi: init header without linking Michael S. Tsirkin
2018-07-10 0:01 ` [Qemu-devel] [PATCH hack dontapply v2 7/7] pc: HACK: acpi: tie in _CST object to Processor Michael S. Tsirkin
2018-07-25 12:37 ` Igor Mammedov
2018-07-25 12:50 ` Michael S. Tsirkin
2018-07-25 14:49 ` Igor Mammedov
2018-07-26 15:49 ` Michael S. Tsirkin
2018-07-27 15:02 ` Igor Mammedov
2018-07-28 20:53 ` Michael S. Tsirkin
2018-07-10 0:10 ` [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation no-reply
2018-07-10 1:49 ` [Qemu-devel] [PATCH hack dontapply v2 8/7 untested] acpi: support cst change notifications Michael S. Tsirkin
2018-07-25 12:32 ` [Qemu-devel] [PATCH hack dontapply v2 0/7] Dynamic _CST generation Igor Mammedov
2018-07-25 12:44 ` Michael S. Tsirkin
2018-07-25 15:53 ` Igor Mammedov
2018-07-26 16:09 ` Michael S. Tsirkin
2018-08-02 9:18 ` Igor Mammedov
2018-08-02 10:00 ` Michael S. Tsirkin
2018-08-08 15:29 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710000024.542612-2-mst@redhat.com \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).