* [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches @ 2018-07-10 6:23 Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 1/3] linux-user: Do not report "Unsupported syscall" by default Laurent Vivier ` (3 more replies) 0 siblings, 4 replies; 11+ messages in thread From: Laurent Vivier @ 2018-07-10 6:23 UTC (permalink / raw) To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier The following changes since commit 43a473993fd9378bf850dcafa68eb6dee8c300f8: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-07-06 18:18:08 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request for you to fetch changes up to 84ca4fa99d7b6c83ce31e1e41300d55cb4e97dcb: linux-user: Report error message on stderr, rather than stdout (2018-07-09 00:52:50 +0200) ---------------------------------------------------------------- Sanitize linux-user stdout ---------------------------------------------------------------- Philippe Mathieu-Daudé (3): linux-user: Do not report "Unsupported syscall" by default linux-user: Do not report "syscall not implemented" by default linux-user: Report error message on stderr, rather than stdout linux-user/alpha/cpu_loop.c | 2 +- linux-user/cris/cpu_loop.c | 2 +- linux-user/cris/signal.c | 4 ++-- linux-user/microblaze/cpu_loop.c | 6 +++--- linux-user/microblaze/signal.c | 4 ++-- linux-user/nios2/signal.c | 2 +- linux-user/sh4/cpu_loop.c | 2 +- linux-user/sparc/cpu_loop.c | 2 +- linux-user/sparc/signal.c | 4 ++-- linux-user/syscall.c | 2 +- 10 files changed, 15 insertions(+), 15 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Qemu-devel] [PULL 1/3] linux-user: Do not report "Unsupported syscall" by default 2018-07-10 6:23 [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Laurent Vivier @ 2018-07-10 6:23 ` Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 2/3] linux-user: Do not report "syscall not implemented" " Laurent Vivier ` (2 subsequent siblings) 3 siblings, 0 replies; 11+ messages in thread From: Laurent Vivier @ 2018-07-10 6:23 UTC (permalink / raw) To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier, Philippe Mathieu-Daudé From: Philippe Mathieu-Daudé <f4bug@amsat.org> This can still be reported using the "-d unimp" command line option. Fixes: https://bugs.launchpad.net/qemu/+bug/1777226 Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20180706155127.7483-2-f4bug@amsat.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5822e03e28..e4b1b7d7da 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -12757,7 +12757,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, default: unimplemented: - gemu_log("qemu: Unsupported syscall: %d\n", num); + qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num); #if defined(TARGET_NR_setxattr) || defined(TARGET_NR_get_thread_area) || defined(TARGET_NR_getdomainname) || defined(TARGET_NR_set_robust_list) unimplemented_nowarn: #endif -- 2.17.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PULL 2/3] linux-user: Do not report "syscall not implemented" by default 2018-07-10 6:23 [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 1/3] linux-user: Do not report "Unsupported syscall" by default Laurent Vivier @ 2018-07-10 6:23 ` Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 3/3] linux-user: Report error message on stderr, rather than stdout Laurent Vivier 2018-07-10 9:51 ` [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Peter Maydell 3 siblings, 0 replies; 11+ messages in thread From: Laurent Vivier @ 2018-07-10 6:23 UTC (permalink / raw) To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier, Philippe Mathieu-Daudé From: Philippe Mathieu-Daudé <f4bug@amsat.org> This can still be reported using the "-d unimp" command line option. Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/fprintf\(stderr,\s?(".*not implemented\\n")\);/qemu_log_mask(LOG_UNIMP, \1);/g' Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <20180706155127.7483-3-f4bug@amsat.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- linux-user/cris/signal.c | 4 ++-- linux-user/microblaze/signal.c | 4 ++-- linux-user/nios2/signal.c | 2 +- linux-user/sparc/signal.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c index 0b405247cf..1e02194377 100644 --- a/linux-user/cris/signal.c +++ b/linux-user/cris/signal.c @@ -146,7 +146,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, target_sigset_t *set, CPUCRISState *env) { - fprintf(stderr, "CRIS setup_rt_frame: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n"); } long do_sigreturn(CPUCRISState *env) @@ -183,6 +183,6 @@ badframe: long do_rt_sigreturn(CPUCRISState *env) { trace_user_do_rt_sigreturn(env, 0); - fprintf(stderr, "CRIS do_rt_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_rt_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } diff --git a/linux-user/microblaze/signal.c b/linux-user/microblaze/signal.c index 712ee522b2..80950c2181 100644 --- a/linux-user/microblaze/signal.c +++ b/linux-user/microblaze/signal.c @@ -200,7 +200,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, target_sigset_t *set, CPUMBState *env) { - fprintf(stderr, "Microblaze setup_rt_frame: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n"); } long do_sigreturn(CPUMBState *env) @@ -240,6 +240,6 @@ badframe: long do_rt_sigreturn(CPUMBState *env) { trace_user_do_rt_sigreturn(env, 0); - fprintf(stderr, "Microblaze do_rt_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_rt_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } diff --git a/linux-user/nios2/signal.c b/linux-user/nios2/signal.c index 4985dc2212..7d535065ed 100644 --- a/linux-user/nios2/signal.c +++ b/linux-user/nios2/signal.c @@ -203,7 +203,7 @@ give_sigsegv: long do_sigreturn(CPUNios2State *env) { trace_user_do_sigreturn(env, 0); - fprintf(stderr, "do_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c index 55e9d6f9b2..b4c60aa446 100644 --- a/linux-user/sparc/signal.c +++ b/linux-user/sparc/signal.c @@ -278,7 +278,7 @@ void setup_rt_frame(int sig, struct target_sigaction *ka, target_siginfo_t *info, target_sigset_t *set, CPUSPARCState *env) { - fprintf(stderr, "setup_rt_frame: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "setup_rt_frame: not implemented\n"); } long do_sigreturn(CPUSPARCState *env) @@ -357,7 +357,7 @@ segv_and_exit: long do_rt_sigreturn(CPUSPARCState *env) { trace_user_do_rt_sigreturn(env, 0); - fprintf(stderr, "do_rt_sigreturn: not implemented\n"); + qemu_log_mask(LOG_UNIMP, "do_rt_sigreturn: not implemented\n"); return -TARGET_ENOSYS; } -- 2.17.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Qemu-devel] [PULL 3/3] linux-user: Report error message on stderr, rather than stdout 2018-07-10 6:23 [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 1/3] linux-user: Do not report "Unsupported syscall" by default Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 2/3] linux-user: Do not report "syscall not implemented" " Laurent Vivier @ 2018-07-10 6:23 ` Laurent Vivier 2018-07-10 9:51 ` [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Peter Maydell 3 siblings, 0 replies; 11+ messages in thread From: Laurent Vivier @ 2018-07-10 6:23 UTC (permalink / raw) To: qemu-devel; +Cc: Riku Voipio, Laurent Vivier, Philippe Mathieu-Daudé From: Philippe Mathieu-Daudé <f4bug@amsat.org> Code change produced with: git ls-files linux-user | \ xargs sed -i -E 's/(\s+)printf\s*\(("Unhandled.*)\);/\1fprintf(stderr, \2);/g' Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Message-Id: <20180706155127.7483-4-f4bug@amsat.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu> --- linux-user/alpha/cpu_loop.c | 2 +- linux-user/cris/cpu_loop.c | 2 +- linux-user/microblaze/cpu_loop.c | 6 +++--- linux-user/sh4/cpu_loop.c | 2 +- linux-user/sparc/cpu_loop.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/linux-user/alpha/cpu_loop.c b/linux-user/alpha/cpu_loop.c index b87fcaea87..c1a98c8cbf 100644 --- a/linux-user/alpha/cpu_loop.c +++ b/linux-user/alpha/cpu_loop.c @@ -196,7 +196,7 @@ void cpu_loop(CPUAlphaState *env) arch_interrupt = false; break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/cris/cpu_loop.c b/linux-user/cris/cpu_loop.c index 1c5eca9f83..37bdcfa8cc 100644 --- a/linux-user/cris/cpu_loop.c +++ b/linux-user/cris/cpu_loop.c @@ -81,7 +81,7 @@ void cpu_loop(CPUCRISState *env) cpu_exec_step_atomic(cs); break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/microblaze/cpu_loop.c b/linux-user/microblaze/cpu_loop.c index 5af12d5b21..2af93eb39a 100644 --- a/linux-user/microblaze/cpu_loop.c +++ b/linux-user/microblaze/cpu_loop.c @@ -105,8 +105,8 @@ void cpu_loop(CPUMBState *env) queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info); break; default: - printf("Unhandled hw-exception: 0x%" PRIx64 "\n", - env->sregs[SR_ESR] & ESR_EC_MASK); + fprintf(stderr, "Unhandled hw-exception: 0x%" PRIx64 "\n", + env->sregs[SR_ESR] & ESR_EC_MASK); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); break; @@ -130,7 +130,7 @@ void cpu_loop(CPUMBState *env) cpu_exec_step_atomic(cs); break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/sh4/cpu_loop.c b/linux-user/sh4/cpu_loop.c index 418833ea25..fdd348170b 100644 --- a/linux-user/sh4/cpu_loop.c +++ b/linux-user/sh4/cpu_loop.c @@ -84,7 +84,7 @@ void cpu_loop(CPUSH4State *env) arch_interrupt = false; break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } diff --git a/linux-user/sparc/cpu_loop.c b/linux-user/sparc/cpu_loop.c index 7c4796ca23..91f714afc6 100644 --- a/linux-user/sparc/cpu_loop.c +++ b/linux-user/sparc/cpu_loop.c @@ -285,7 +285,7 @@ void cpu_loop (CPUSPARCState *env) cpu_exec_step_atomic(cs); break; default: - printf ("Unhandled trap: 0x%x\n", trapnr); + fprintf(stderr, "Unhandled trap: 0x%x\n", trapnr); cpu_dump_state(cs, stderr, fprintf, 0); exit(EXIT_FAILURE); } -- 2.17.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches 2018-07-10 6:23 [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Laurent Vivier ` (2 preceding siblings ...) 2018-07-10 6:23 ` [Qemu-devel] [PULL 3/3] linux-user: Report error message on stderr, rather than stdout Laurent Vivier @ 2018-07-10 9:51 ` Peter Maydell 3 siblings, 0 replies; 11+ messages in thread From: Peter Maydell @ 2018-07-10 9:51 UTC (permalink / raw) To: Laurent Vivier; +Cc: QEMU Developers, Riku Voipio On 10 July 2018 at 07:23, Laurent Vivier <laurent@vivier.eu> wrote: > The following changes since commit 43a473993fd9378bf850dcafa68eb6dee8c300f8: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-07-06 18:18:08 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request > > for you to fetch changes up to 84ca4fa99d7b6c83ce31e1e41300d55cb4e97dcb: > > linux-user: Report error message on stderr, rather than stdout (2018-07-09 00:52:50 +0200) > > ---------------------------------------------------------------- > Sanitize linux-user stdout > > ---------------------------------------------------------------- > > Philippe Mathieu-Daudé (3): > linux-user: Do not report "Unsupported syscall" by default > linux-user: Do not report "syscall not implemented" by default > linux-user: Report error message on stderr, rather than stdout > Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches @ 2018-07-31 8:42 Laurent Vivier 2018-07-31 12:24 ` no-reply 2018-07-31 14:01 ` Peter Maydell 0 siblings, 2 replies; 11+ messages in thread From: Laurent Vivier @ 2018-07-31 8:42 UTC (permalink / raw) To: qemu-devel; +Cc: Riku Voipio, Alex Bennée, Laurent Vivier The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: Merge remote-tracking branch 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 09:55:47 +0100) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request for you to fetch changes up to 5d9f3ea0817215ad4baac5aa30414e9ebbaaf0d6: linux-user: ppc64: don't use volatile register during safe_syscall (2018-07-31 09:57:43 +0200) ---------------------------------------------------------------- Fix safe_syscall() on ppc64 host Fix mmap() 0 length error case ---------------------------------------------------------------- Alex Bennée (2): linux-user/mmap.c: handle invalid len maps correctly tests: add check_invalid_maps to test-mmap Shivaprasad G Bhat (1): linux-user: ppc64: don't use volatile register during safe_syscall linux-user/host/ppc64/safe-syscall.inc.S | 8 ++++++-- linux-user/mmap.c | 15 ++++++++++++--- tests/tcg/multiarch/test-mmap.c | 22 +++++++++++++++++++++- 3 files changed, 39 insertions(+), 6 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches 2018-07-31 8:42 Laurent Vivier @ 2018-07-31 12:24 ` no-reply 2018-07-31 12:40 ` Laurent Vivier 2018-07-31 14:01 ` Peter Maydell 1 sibling, 1 reply; 11+ messages in thread From: no-reply @ 2018-07-31 12:24 UTC (permalink / raw) To: laurent; +Cc: famz, qemu-devel, riku.voipio, alex.bennee Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180731084203.29959-1-laurent@vivier.eu Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 806398c875 linux-user: ppc64: don't use volatile register during safe_syscall ba78346662 tests: add check_invalid_maps to test-mmap 80fc1be868 linux-user/mmap.c: handle invalid len maps correctly === OUTPUT BEGIN === Checking PATCH 1/3: linux-user/mmap.c: handle invalid len maps correctly... Checking PATCH 2/3: tests: add check_invalid_maps to test-mmap... ERROR: code indent should never use tabs #62: FILE: tests/tcg/multiarch/test-mmap.c:498: +^Icheck_invalid_mmaps();$ total: 1 errors, 0 warnings, 40 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/3: linux-user: ppc64: don't use volatile register during safe_syscall... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches 2018-07-31 12:24 ` no-reply @ 2018-07-31 12:40 ` Laurent Vivier 2018-07-31 12:44 ` Laurent Vivier 2018-07-31 13:27 ` Alex Bennée 0 siblings, 2 replies; 11+ messages in thread From: Laurent Vivier @ 2018-07-31 12:40 UTC (permalink / raw) To: qemu-devel; +Cc: famz, riku.voipio, alex.bennee Le 31/07/2018 à 14:24, no-reply@patchew.org a écrit : > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20180731084203.29959-1-laurent@vivier.eu > Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > git config --local diff.algorithm histogram > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > 806398c875 linux-user: ppc64: don't use volatile register during safe_syscall > ba78346662 tests: add check_invalid_maps to test-mmap > 80fc1be868 linux-user/mmap.c: handle invalid len maps correctly > > === OUTPUT BEGIN === > Checking PATCH 1/3: linux-user/mmap.c: handle invalid len maps correctly... > Checking PATCH 2/3: tests: add check_invalid_maps to test-mmap... > ERROR: code indent should never use tabs > #62: FILE: tests/tcg/multiarch/test-mmap.c:498: > +^Icheck_invalid_mmaps();$ > > total: 1 errors, 0 warnings, 40 lines checked I'm going to resend a pull request without the tab. Thanks, Laurent ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches 2018-07-31 12:40 ` Laurent Vivier @ 2018-07-31 12:44 ` Laurent Vivier 2018-07-31 13:27 ` Alex Bennée 1 sibling, 0 replies; 11+ messages in thread From: Laurent Vivier @ 2018-07-31 12:44 UTC (permalink / raw) To: qemu-devel; +Cc: famz, riku.voipio, alex.bennee Le 31/07/2018 à 14:40, Laurent Vivier a écrit : > Le 31/07/2018 à 14:24, no-reply@patchew.org a écrit : >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 20180731084203.29959-1-laurent@vivier.eu >> Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> >> BASE=base >> n=1 >> total=$(git log --oneline $BASE.. | wc -l) >> failed=0 >> >> git config --local diff.renamelimit 0 >> git config --local diff.renames True >> git config --local diff.algorithm histogram >> >> commits="$(git log --format=%H --reverse $BASE..)" >> for c in $commits; do >> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." >> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then >> failed=1 >> echo >> fi >> n=$((n+1)) >> done >> >> exit $failed >> === TEST SCRIPT END === >> >> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 >> Switched to a new branch 'test' >> 806398c875 linux-user: ppc64: don't use volatile register during safe_syscall >> ba78346662 tests: add check_invalid_maps to test-mmap >> 80fc1be868 linux-user/mmap.c: handle invalid len maps correctly >> >> === OUTPUT BEGIN === >> Checking PATCH 1/3: linux-user/mmap.c: handle invalid len maps correctly... >> Checking PATCH 2/3: tests: add check_invalid_maps to test-mmap... >> ERROR: code indent should never use tabs >> #62: FILE: tests/tcg/multiarch/test-mmap.c:498: >> +^Icheck_invalid_mmaps();$ >> >> total: 1 errors, 0 warnings, 40 lines checked > > I'm going to resend a pull request without the tab. In fact, no, the whole file uses tabulation. I will not change that. Peter, could you take the series as-is? Thanks, Laurent ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches 2018-07-31 12:40 ` Laurent Vivier 2018-07-31 12:44 ` Laurent Vivier @ 2018-07-31 13:27 ` Alex Bennée 1 sibling, 0 replies; 11+ messages in thread From: Alex Bennée @ 2018-07-31 13:27 UTC (permalink / raw) To: Laurent Vivier; +Cc: qemu-devel, famz, riku.voipio Laurent Vivier <laurent@vivier.eu> writes: > Le 31/07/2018 à 14:24, no-reply@patchew.org a écrit: >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Type: series >> Message-id: 20180731084203.29959-1-laurent@vivier.eu >> Subject: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> >> BASE=base >> n=1 >> total=$(git log --oneline $BASE.. | wc -l) >> failed=0 >> >> git config --local diff.renamelimit 0 >> git config --local diff.renames True >> git config --local diff.algorithm histogram >> >> commits="$(git log --format=%H --reverse $BASE..)" >> for c in $commits; do >> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." >> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then >> failed=1 >> echo >> fi >> n=$((n+1)) >> done >> >> exit $failed >> === TEST SCRIPT END === >> >> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 >> Switched to a new branch 'test' >> 806398c875 linux-user: ppc64: don't use volatile register during safe_syscall >> ba78346662 tests: add check_invalid_maps to test-mmap >> 80fc1be868 linux-user/mmap.c: handle invalid len maps correctly >> >> === OUTPUT BEGIN === >> Checking PATCH 1/3: linux-user/mmap.c: handle invalid len maps correctly... >> Checking PATCH 2/3: tests: add check_invalid_maps to test-mmap... >> ERROR: code indent should never use tabs >> #62: FILE: tests/tcg/multiarch/test-mmap.c:498: >> +^Icheck_invalid_mmaps();$ Sorry I should of flagged this in the commit message. I left the touched bits as is and used spaces for new functions. >> >> total: 1 errors, 0 warnings, 40 lines checked > > I'm going to resend a pull request without the tab. > > Thanks, > Laurent -- Alex Bennée ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches 2018-07-31 8:42 Laurent Vivier 2018-07-31 12:24 ` no-reply @ 2018-07-31 14:01 ` Peter Maydell 1 sibling, 0 replies; 11+ messages in thread From: Peter Maydell @ 2018-07-31 14:01 UTC (permalink / raw) To: Laurent Vivier; +Cc: QEMU Developers, Riku Voipio, Alex Bennée On 31 July 2018 at 09:42, Laurent Vivier <laurent@vivier.eu> wrote: > The following changes since commit 6d9dd5fb9d0e9f4a174f53a0e20a39fbe809c71e: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qobject-2018-07-27-v2' into staging (2018-07-30 09:55:47 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request > > for you to fetch changes up to 5d9f3ea0817215ad4baac5aa30414e9ebbaaf0d6: > > linux-user: ppc64: don't use volatile register during safe_syscall (2018-07-31 09:57:43 +0200) > > ---------------------------------------------------------------- > Fix safe_syscall() on ppc64 host > Fix mmap() 0 length error case > > ---------------------------------------------------------------- Applied, thanks. -- PMM ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-07-31 14:01 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-07-10 6:23 [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 1/3] linux-user: Do not report "Unsupported syscall" by default Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 2/3] linux-user: Do not report "syscall not implemented" " Laurent Vivier 2018-07-10 6:23 ` [Qemu-devel] [PULL 3/3] linux-user: Report error message on stderr, rather than stdout Laurent Vivier 2018-07-10 9:51 ` [Qemu-devel] [PULL 0/3] Linux user for 3.0 patches Peter Maydell -- strict thread matches above, loose matches on Subject: below -- 2018-07-31 8:42 Laurent Vivier 2018-07-31 12:24 ` no-reply 2018-07-31 12:40 ` Laurent Vivier 2018-07-31 12:44 ` Laurent Vivier 2018-07-31 13:27 ` Alex Bennée 2018-07-31 14:01 ` Peter Maydell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).