From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
vsementsov@virtuozzo.com, qemu-block@nongnu.org,
Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, Jeff Cody <jcody@redhat.com>,
Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v3 09/10] block: Fix bdrv_co_truncate overlap check
Date: Tue, 10 Jul 2018 14:31:23 +0800 [thread overview]
Message-ID: <20180710063124.2263-10-famz@redhat.com> (raw)
In-Reply-To: <20180710063124.2263-1-famz@redhat.com>
If we are growing the image and potentially using preallocation for the
new area, we need to make sure that no write requests are made to the
"preallocated" area which is [@old_size, @offset), not
[@offset, offset * 2 - @old_size).
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
block/io.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/io.c b/block/io.c
index 9687da1ce9..e3e2d5286d 100644
--- a/block/io.c
+++ b/block/io.c
@@ -3113,7 +3113,8 @@ int coroutine_fn bdrv_co_truncate(BdrvChild *child, int64_t offset,
}
bdrv_inc_in_flight(bs);
- tracked_request_begin(&req, bs, offset, new_bytes, BDRV_TRACKED_TRUNCATE);
+ tracked_request_begin(&req, bs, offset - new_bytes, new_bytes,
+ BDRV_TRACKED_TRUNCATE);
/* If we are growing the image and potentially using preallocation for the
* new area, we need to make sure that no write requests are made to it
--
2.17.1
next prev parent reply other threads:[~2018-07-10 6:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 6:31 [Qemu-devel] [PATCH v3 00/10] block: Fix dst reading after tail copy offloading Fam Zheng
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 01/10] block: Prefix file driver trace points with "file_" Fam Zheng
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 02/10] block: Add copy offloading trace points Fam Zheng
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 03/10] block: Use BdrvChild to discard Fam Zheng
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 04/10] block: Use uint64_t for BdrvTrackedRequest byte fields Fam Zheng
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 05/10] block: Extract common write req handling Fam Zheng
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 06/10] block: Fix handling of image enlarging write Fam Zheng
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 07/10] block: Use common req handling for discard Fam Zheng
2018-07-10 14:45 ` Kevin Wolf
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 08/10] block: Use common req handling in copy offloading Fam Zheng
2018-07-10 6:31 ` Fam Zheng [this message]
2018-07-10 6:31 ` [Qemu-devel] [PATCH v3 10/10] block: Use common write req handling in truncate Fam Zheng
2018-07-10 14:46 ` [Qemu-devel] [PATCH v3 00/10] block: Fix dst reading after tail copy offloading Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710063124.2263-10-famz@redhat.com \
--to=famz@redhat.com \
--cc=eblake@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).