From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: peterx@redhat.com, Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Balamuruhan S <bala24@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH for-3.0 v2 10/10] tests: hide stderr for postcopy recovery test
Date: Tue, 10 Jul 2018 17:19:02 +0800 [thread overview]
Message-ID: <20180710091902.28780-11-peterx@redhat.com> (raw)
In-Reply-To: <20180710091902.28780-1-peterx@redhat.com>
We dumped something when network failure happens. We should avoid those
messages to be dumped when running the tests:
$ ./tests/migration-test -p /x86_64/migration/postcopy/recovery
/x86_64/migration/postcopy/recovery: qemu-system-x86_64: check_section_footer: Read section footer failed: -5
qemu-system-x86_64: Detected IO failure for postcopy. Migration paused.
qemu-system-x86_64: Detected IO failure for postcopy. Migration paused.
OK
After the patch:
$ ./tests/migration-test -p /x86_64/migration/postcopy/recovery
/x86_64/migration/postcopy/recovery: OK
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
tests/migration-test.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index e952d94529..45558446f1 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -567,12 +567,13 @@ static void test_deprecated(void)
}
static void migrate_postcopy_prepare(QTestState **from_ptr,
- QTestState **to_ptr)
+ QTestState **to_ptr,
+ bool hide_error)
{
char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
QTestState *from, *to;
- test_migrate_start(&from, &to, uri, false);
+ test_migrate_start(&from, &to, uri, hide_error);
migrate_set_capability(from, "postcopy-ram", "true");
migrate_set_capability(to, "postcopy-ram", "true");
@@ -615,7 +616,7 @@ static void test_postcopy(void)
{
QTestState *from, *to;
- migrate_postcopy_prepare(&from, &to);
+ migrate_postcopy_prepare(&from, &to, false);
migrate_postcopy_start(from, to);
migrate_postcopy_complete(from, to);
}
@@ -625,7 +626,7 @@ static void test_postcopy_recovery(void)
QTestState *from, *to;
char *uri;
- migrate_postcopy_prepare(&from, &to);
+ migrate_postcopy_prepare(&from, &to, true);
/* Turn postcopy speed down, 4K/s is slow enough on any machines */
migrate_set_parameter(from, "max-postcopy-bandwidth", "4096");
--
2.17.1
next prev parent reply other threads:[~2018-07-10 9:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 9:18 [Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 01/10] migration: simplify check to use qemu file buffer Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 02/10] migration: loosen recovery check when load vm Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 03/10] migration: fix incorrect bitmap size calculation Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 04/10] migration: show pause/recover state on dst host Peter Xu
2018-07-10 11:20 ` Dr. David Alan Gilbert
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 05/10] tests: introduce migrate_postcopy_* helpers Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 06/10] tests: allow migrate() to take extra flags Peter Xu
2018-07-10 9:18 ` [Qemu-devel] [PATCH for-3.0 v2 07/10] tests: introduce migrate_query*() helpers Peter Xu
2018-07-10 9:19 ` [Qemu-devel] [PATCH for-3.0 v2 08/10] tests: introduce wait_for_migration_status() Peter Xu
2018-07-10 9:19 ` [Qemu-devel] [PATCH for-3.0 v2 09/10] tests: add postcopy recovery test Peter Xu
2018-07-10 11:25 ` Dr. David Alan Gilbert
2018-07-10 12:23 ` Juan Quintela
2018-07-10 9:19 ` Peter Xu [this message]
2018-07-10 12:18 ` [Qemu-devel] [PATCH for-3.0 v2 00/10] migration: postcopy recovery unit test, bug fixes Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710091902.28780-11-peterx@redhat.com \
--to=peterx@redhat.com \
--cc=bala24@linux.vnet.ibm.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).