From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcooL-0003Ns-1L for qemu-devel@nongnu.org; Tue, 10 Jul 2018 05:19:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcooK-00037t-1l for qemu-devel@nongnu.org; Tue, 10 Jul 2018 05:19:53 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36630 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fcooJ-00037o-T6 for qemu-devel@nongnu.org; Tue, 10 Jul 2018 05:19:51 -0400 From: Peter Xu Date: Tue, 10 Jul 2018 17:19:02 +0800 Message-Id: <20180710091902.28780-11-peterx@redhat.com> In-Reply-To: <20180710091902.28780-1-peterx@redhat.com> References: <20180710091902.28780-1-peterx@redhat.com> Subject: [Qemu-devel] [PATCH for-3.0 v2 10/10] tests: hide stderr for postcopy recovery test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peterx@redhat.com, Juan Quintela , "Dr . David Alan Gilbert" , Balamuruhan S We dumped something when network failure happens. We should avoid those messages to be dumped when running the tests: $ ./tests/migration-test -p /x86_64/migration/postcopy/recovery /x86_64/migration/postcopy/recovery: qemu-system-x86_64: check_section_footer: Read section footer failed: -5 qemu-system-x86_64: Detected IO failure for postcopy. Migration paused. qemu-system-x86_64: Detected IO failure for postcopy. Migration paused. OK After the patch: $ ./tests/migration-test -p /x86_64/migration/postcopy/recovery /x86_64/migration/postcopy/recovery: OK Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Peter Xu --- tests/migration-test.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/migration-test.c b/tests/migration-test.c index e952d94529..45558446f1 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -567,12 +567,13 @@ static void test_deprecated(void) } static void migrate_postcopy_prepare(QTestState **from_ptr, - QTestState **to_ptr) + QTestState **to_ptr, + bool hide_error) { char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs); QTestState *from, *to; - test_migrate_start(&from, &to, uri, false); + test_migrate_start(&from, &to, uri, hide_error); migrate_set_capability(from, "postcopy-ram", "true"); migrate_set_capability(to, "postcopy-ram", "true"); @@ -615,7 +616,7 @@ static void test_postcopy(void) { QTestState *from, *to; - migrate_postcopy_prepare(&from, &to); + migrate_postcopy_prepare(&from, &to, false); migrate_postcopy_start(from, to); migrate_postcopy_complete(from, to); } @@ -625,7 +626,7 @@ static void test_postcopy_recovery(void) QTestState *from, *to; char *uri; - migrate_postcopy_prepare(&from, &to); + migrate_postcopy_prepare(&from, &to, true); /* Turn postcopy speed down, 4K/s is slow enough on any machines */ migrate_set_parameter(from, "max-postcopy-bandwidth", "4096"); -- 2.17.1