From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcrcJ-0006xQ-J7 for qemu-devel@nongnu.org; Tue, 10 Jul 2018 08:19:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcrcF-0002oq-Gh for qemu-devel@nongnu.org; Tue, 10 Jul 2018 08:19:39 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37354 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fcrcF-0002oO-Bn for qemu-devel@nongnu.org; Tue, 10 Jul 2018 08:19:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 08CE514B39E for ; Tue, 10 Jul 2018 12:19:35 +0000 (UTC) Date: Tue, 10 Jul 2018 13:19:29 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180710121929.GB37263@work-vm> References: <20180710094424.30754-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180710094424.30754-1-peterx@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-3.0] migration: reorder MIG_CMD_POSTCOPY_RESUME List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Juan Quintela * Peter Xu (peterx@redhat.com) wrote: > It was accidently added before MIG_CMD_PACKAGED so it might break > command compatibility when we run postcopy migration between old/new > QEMUs. Fix that up quickly before the QEMU 3.0 release. >=20 > Reported-by: Luk=C3=A1=C5=A1 Doktor > Suggested-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu Queued > --- > migration/savevm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/migration/savevm.c b/migration/savevm.c > index c2f34ffc7c..0d2c4a0739 100644 > --- a/migration/savevm.c > +++ b/migration/savevm.c > @@ -81,8 +81,8 @@ enum qemu_vm_cmd { > MIG_CMD_POSTCOPY_RAM_DISCARD, /* A list of pages to discard that > were previously sent during > precopy but are dirty. */ > - MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */ > MIG_CMD_PACKAGED, /* Send a wrapped stream within this st= ream */ > + MIG_CMD_POSTCOPY_RESUME, /* resume postcopy on dest */ > MIG_CMD_RECV_BITMAP, /* Request for recved bitmap on dst */ > MIG_CMD_MAX > }; > --=20 > 2.17.1 >=20 -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK