From: Stefan Hajnoczi <stefanha@gmail.com>
To: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: mjt@tls.msk.ru, laurent@vivier.eu, stefanha@redhat.com,
qemu-trivial@nongnu.org, armbru@redhat.com,
qemu-devel@nongnu.org, cota@braap.org
Subject: Re: [Qemu-devel] [PATCH v2] tracing: Use double-dash spelling for trace option
Date: Tue, 10 Jul 2018 15:17:28 +0100 [thread overview]
Message-ID: <20180710141728.GD30635@stefanha-x1.localdomain> (raw)
In-Reply-To: <1530674247-31200-1-git-send-email-baiyaowei@cmss.chinamobile.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Wed, Jul 04, 2018 at 11:17:27AM +0800, Yaowei Bai wrote:
> The '-trace' and '--trace' spellings are only both supported in qemu
> binary, while for qemu-nbd or qemu-img only '--trace' spelling is
> supported. So for the consistency of trace option invocation, we
> should use double-dash spelling in our documentation.
>
> This's also mentioned in
> https://wiki.qemu.org/BiteSizedTasks#Consistent_option_usage_in_documentation
> .
>
> Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> docs/devel/tracing.txt | 6 +++---
> trace/control.c | 4 ++--
> trace/control.h | 4 ++--
> 3 files changed, 7 insertions(+), 7 deletions(-)
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
prev parent reply other threads:[~2018-07-10 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 3:17 [Qemu-devel] [PATCH v2] tracing: Use double-dash spelling for trace option Yaowei Bai
2018-07-10 14:17 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710141728.GD30635@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=cota@braap.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).