qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, peterx@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PULL 14/15] tests: hide stderr for postcopy recovery test
Date: Tue, 10 Jul 2018 16:30:15 +0100	[thread overview]
Message-ID: <20180710153016.131258-15-dgilbert@redhat.com> (raw)
In-Reply-To: <20180710153016.131258-1-dgilbert@redhat.com>

From: Peter Xu <peterx@redhat.com>

We dumped something when network failure happens.  We should avoid those
messages to be dumped when running the tests:

  $ ./tests/migration-test -p /x86_64/migration/postcopy/recovery
  /x86_64/migration/postcopy/recovery: qemu-system-x86_64: check_section_footer: Read section footer failed: -5
  qemu-system-x86_64: Detected IO failure for postcopy. Migration paused.
  qemu-system-x86_64: Detected IO failure for postcopy. Migration paused.
  OK

After the patch:

  $ ./tests/migration-test -p /x86_64/migration/postcopy/recovery
  /x86_64/migration/postcopy/recovery: OK

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180710091902.28780-11-peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 tests/migration-test.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index d8b2633fce..086f727b34 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -572,12 +572,13 @@ static void test_deprecated(void)
 }
 
 static int migrate_postcopy_prepare(QTestState **from_ptr,
-                                     QTestState **to_ptr)
+                                     QTestState **to_ptr,
+                                     bool hide_error)
 {
     char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
     QTestState *from, *to;
 
-    if (test_migrate_start(&from, &to, uri, false)) {
+    if (test_migrate_start(&from, &to, uri, hide_error)) {
         return -1;
     }
 
@@ -624,7 +625,7 @@ static void test_postcopy(void)
 {
     QTestState *from, *to;
 
-    if (migrate_postcopy_prepare(&from, &to)) {
+    if (migrate_postcopy_prepare(&from, &to, false)) {
         return;
     }
     migrate_postcopy_start(from, to);
@@ -636,7 +637,7 @@ static void test_postcopy_recovery(void)
     QTestState *from, *to;
     char *uri;
 
-    if (migrate_postcopy_prepare(&from, &to)) {
+    if (migrate_postcopy_prepare(&from, &to, true)) {
         return;
     }
 
-- 
2.17.1

  parent reply	other threads:[~2018-07-10 15:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 15:30 [Qemu-devel] [PULL 00/15] migration queue Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 01/15] migration: delay postcopy paused state Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 02/15] migration: move income process out of multifd Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 03/15] migration: unbreak postcopy recovery Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 04/15] migration: unify incoming processing Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 05/15] migration: simplify check to use qemu file buffer Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 06/15] migration: loosen recovery check when load vm Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 07/15] migration: fix incorrect bitmap size calculation Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 08/15] migration: show pause/recover state on dst host Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 09/15] tests: introduce migrate_postcopy_* helpers Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 10/15] tests: allow migrate() to take extra flags Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 11/15] tests: introduce migrate_query*() helpers Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 12/15] tests: introduce wait_for_migration_status() Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` [Qemu-devel] [PULL 13/15] tests: add postcopy recovery test Dr. David Alan Gilbert (git)
2018-07-10 15:30 ` Dr. David Alan Gilbert (git) [this message]
2018-07-10 15:30 ` [Qemu-devel] [PULL 15/15] migration: reorder MIG_CMD_POSTCOPY_RESUME Dr. David Alan Gilbert (git)
2018-07-10 16:28 ` [Qemu-devel] [PULL 00/15] migration queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710153016.131258-15-dgilbert@redhat.com \
    --to=dgilbert@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).