From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcupq-0007bj-Eg for qemu-devel@nongnu.org; Tue, 10 Jul 2018 11:45:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcupp-0002eO-JC for qemu-devel@nongnu.org; Tue, 10 Jul 2018 11:45:50 -0400 Date: Tue, 10 Jul 2018 17:45:36 +0200 From: Kevin Wolf Message-ID: <20180710154536.GN5852@localhost.localdomain> References: <20180710093802.28308-1-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: Fam Zheng , qemu-devel@nongnu.org, vsementsov@virtuozzo.com, qemu-block@nongnu.org, Max Reitz Am 10.07.2018 um 17:34 hat John Snow geschrieben: > > > On 07/10/2018 05:38 AM, Fam Zheng wrote: > > Luks needs special parameters to operate the image. Since this test is > > focusing on image fleecing, skip skip that format. > > > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-iotests/222 | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222 > > index ff3bfc1470..0ead56d574 100644 > > --- a/tests/qemu-iotests/222 > > +++ b/tests/qemu-iotests/222 > > @@ -25,6 +25,8 @@ import iotests > > from iotests import log, qemu_img, qemu_io, qemu_io_silent > > > > iotests.verify_platform(['linux']) > > +iotests.verify_image_format(supported_fmts=['qcow2', 'qcow', 'qed', 'vmdk', > > + 'vhdx', 'raw']) > > > > patterns = [("0x5d", "0", "64k"), > > ("0xd5", "1M", "64k"), > > > > Ah; do we not have a nicer way to exclude just one format? Evidently not. iotest.verify_image_format() has an argument unsupported_fmts, but I think a whitelist is better anyway. Kevin