* [Qemu-devel] [PATCH] iotests: 222: Don't run with luks
@ 2018-07-10 9:38 Fam Zheng
2018-07-10 9:58 ` Kevin Wolf
2018-07-10 15:34 ` John Snow
0 siblings, 2 replies; 4+ messages in thread
From: Fam Zheng @ 2018-07-10 9:38 UTC (permalink / raw)
To: qemu-devel; +Cc: jsnow, vsementsov, Kevin Wolf, Max Reitz, qemu-block
Luks needs special parameters to operate the image. Since this test is
focusing on image fleecing, skip skip that format.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/qemu-iotests/222 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
index ff3bfc1470..0ead56d574 100644
--- a/tests/qemu-iotests/222
+++ b/tests/qemu-iotests/222
@@ -25,6 +25,8 @@ import iotests
from iotests import log, qemu_img, qemu_io, qemu_io_silent
iotests.verify_platform(['linux'])
+iotests.verify_image_format(supported_fmts=['qcow2', 'qcow', 'qed', 'vmdk',
+ 'vhdx', 'raw'])
patterns = [("0x5d", "0", "64k"),
("0xd5", "1M", "64k"),
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks
2018-07-10 9:38 [Qemu-devel] [PATCH] iotests: 222: Don't run with luks Fam Zheng
@ 2018-07-10 9:58 ` Kevin Wolf
2018-07-10 15:34 ` John Snow
1 sibling, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2018-07-10 9:58 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, jsnow, vsementsov, Max Reitz, qemu-block
Am 10.07.2018 um 11:38 hat Fam Zheng geschrieben:
> Luks needs special parameters to operate the image. Since this test is
> focusing on image fleecing, skip skip that format.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks
2018-07-10 9:38 [Qemu-devel] [PATCH] iotests: 222: Don't run with luks Fam Zheng
2018-07-10 9:58 ` Kevin Wolf
@ 2018-07-10 15:34 ` John Snow
2018-07-10 15:45 ` Kevin Wolf
1 sibling, 1 reply; 4+ messages in thread
From: John Snow @ 2018-07-10 15:34 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Kevin Wolf, vsementsov, qemu-block, Max Reitz
On 07/10/2018 05:38 AM, Fam Zheng wrote:
> Luks needs special parameters to operate the image. Since this test is
> focusing on image fleecing, skip skip that format.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/qemu-iotests/222 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
> index ff3bfc1470..0ead56d574 100644
> --- a/tests/qemu-iotests/222
> +++ b/tests/qemu-iotests/222
> @@ -25,6 +25,8 @@ import iotests
> from iotests import log, qemu_img, qemu_io, qemu_io_silent
>
> iotests.verify_platform(['linux'])
> +iotests.verify_image_format(supported_fmts=['qcow2', 'qcow', 'qed', 'vmdk',
> + 'vhdx', 'raw'])
>
> patterns = [("0x5d", "0", "64k"),
> ("0xd5", "1M", "64k"),
>
Ah; do we not have a nicer way to exclude just one format? Evidently not.
Apologies for breaking LUKS.
--js
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks
2018-07-10 15:34 ` John Snow
@ 2018-07-10 15:45 ` Kevin Wolf
0 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2018-07-10 15:45 UTC (permalink / raw)
To: John Snow; +Cc: Fam Zheng, qemu-devel, vsementsov, qemu-block, Max Reitz
Am 10.07.2018 um 17:34 hat John Snow geschrieben:
>
>
> On 07/10/2018 05:38 AM, Fam Zheng wrote:
> > Luks needs special parameters to operate the image. Since this test is
> > focusing on image fleecing, skip skip that format.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > tests/qemu-iotests/222 | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
> > index ff3bfc1470..0ead56d574 100644
> > --- a/tests/qemu-iotests/222
> > +++ b/tests/qemu-iotests/222
> > @@ -25,6 +25,8 @@ import iotests
> > from iotests import log, qemu_img, qemu_io, qemu_io_silent
> >
> > iotests.verify_platform(['linux'])
> > +iotests.verify_image_format(supported_fmts=['qcow2', 'qcow', 'qed', 'vmdk',
> > + 'vhdx', 'raw'])
> >
> > patterns = [("0x5d", "0", "64k"),
> > ("0xd5", "1M", "64k"),
> >
>
> Ah; do we not have a nicer way to exclude just one format? Evidently not.
iotest.verify_image_format() has an argument unsupported_fmts, but I
think a whitelist is better anyway.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-10 15:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-10 9:38 [Qemu-devel] [PATCH] iotests: 222: Don't run with luks Fam Zheng
2018-07-10 9:58 ` Kevin Wolf
2018-07-10 15:34 ` John Snow
2018-07-10 15:45 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).