[Qemu-devel] [PULL 0/1] Monitor patches for 2018-07-11

[Qemu-devel] [PULL 0/1] Monitor patches for 2018-07-11

[Markus Armbruster]

The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc:

  Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018-07-11

for you to fetch changes up to 42eab8dbec2f3fd4a14bd63ab01aa155ce5724a3:

  monitor: fix double-free of request error (2018-07-11 21:11:15 +0200)

----------------------------------------------------------------
Monitor patches for 2018-07-11

----------------------------------------------------------------
Marc-André Lureau (1):
      monitor: fix double-free of request error

 monitor.c | 1 +
 1 file changed, 1 insertion(+)

Marc-André Lureau (1):
  monitor: fix double-free of request error

 monitor.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.1

[Qemu-devel] [PULL 1/1] monitor: fix double-free of request error

[Markus Armbruster]

From: Marc-André Lureau <marcandre.lureau@redhat.com>

qmp_error_response() will free the given error. Fix double-free in
later qmp_request_free().

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20180705164201.9853-1-marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Fixes: 1cc37471525d03f963bc71d724f0dc9eab888fc1
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 monitor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/monitor.c b/monitor.c
index 3c9c97b73f..7af1f18d13 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4186,6 +4186,7 @@ static void monitor_qmp_bh_dispatcher(void *data)
     } else {
         assert(req_obj->err);
         rsp = qmp_error_response(req_obj->err);
+        req_obj->err = NULL;
         monitor_qmp_respond(req_obj->mon, rsp, NULL);
         qobject_unref(rsp);
     }
-- 
2.17.1

Re: [Qemu-devel] [PULL 0/1] Monitor patches for 2018-07-11

[Peter Maydell]

On 11 July 2018 at 20:14, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit c447afd5783b9237fa51b7a85777007d8d568bfc:
>
>   Update version for v3.0.0-rc0 release (2018-07-10 18:19:50 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-monitor-2018-07-11
>
> for you to fetch changes up to 42eab8dbec2f3fd4a14bd63ab01aa155ce5724a3:
>
>   monitor: fix double-free of request error (2018-07-11 21:11:15 +0200)
>
> ----------------------------------------------------------------
> Monitor patches for 2018-07-11
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM