From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Viktor Prutyanov <viktor.prutyanov@virtuozzo.com>,
qemu-devel@nongnu.org, rth@twiddle.net, rkagan@virtuozzo.com
Subject: Re: [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state
Date: Wed, 11 Jul 2018 16:19:16 -0300 [thread overview]
Message-ID: <20180711191916.GZ7451@localhost.localdomain> (raw)
In-Reply-To: <5e03b9eb-22ce-69bf-ca04-a17201834dfb@redhat.com>
On Wed, Jul 11, 2018 at 06:19:33PM +0200, Paolo Bonzini wrote:
> On 11/07/2018 18:00, Eduardo Habkost wrote:
> >> @@ -237,7 +237,7 @@ int x86_cpu_write_elf32_note(WriteCoreDumpFunction f, CPUState *cs,
> >> * please count up QEMUCPUSTATE_VERSION if you have changed definition of
> >> * QEMUCPUState, and modify the tools using this information accordingly.
> > Where are the tools using this information, that need to be
> > updated? Won't this break existing versions of those tools?
>
> I think it's okay to _not_ change the version, since the format is
> backwards-compatible. Each QEMUCPUState struct is in a separate ELF
> note, and the presence of the new field is visible in both 1) the size
> of the note 2) the size field of the struct.
If we do it, can we please make the documentation (or at least
code comments, as documentation doesn't seem to exist) clearly
state that the new field is optional in version 1?
--
Eduardo
next prev parent reply other threads:[~2018-07-11 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 15:21 [Qemu-devel] [PATCH] dump: add kernel_gs_base to QEMU CPU state Viktor Prutyanov
2018-07-11 16:00 ` Eduardo Habkost
2018-07-11 16:19 ` Paolo Bonzini
2018-07-11 19:19 ` Eduardo Habkost [this message]
2018-07-11 16:26 ` Viktor Prutyanov
2018-07-11 16:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711191916.GZ7451@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=rth@twiddle.net \
--cc=viktor.prutyanov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).