qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 3/7] qemu-img: Document copy offloading implications with -S and -c
Date: Thu, 12 Jul 2018 18:31:48 +0200	[thread overview]
Message-ID: <20180712163152.12521-4-kwolf@redhat.com> (raw)
In-Reply-To: <20180712163152.12521-1-kwolf@redhat.com>

From: Fam Zheng <famz@redhat.com>

Explicitly enabling zero detection or compression suppresses copy
offloading during convert. Document it.

Suggested-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-img.texi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/qemu-img.texi b/qemu-img.texi
index aeb1b9e66c..5853cd18d1 100644
--- a/qemu-img.texi
+++ b/qemu-img.texi
@@ -96,7 +96,8 @@ will enumerate information about backing files in a disk image chain. Refer
 below for further description.
 
 @item -c
-indicates that target image must be compressed (qcow format only)
+indicates that target image must be compressed (qcow format only). If this
+option is used, copy offloading will not be attempted.
 
 @item -h
 with or without a command shows help and lists the supported formats
@@ -115,7 +116,8 @@ in case both @var{-q} and @var{-p} options are used.
 indicates the consecutive number of bytes that must contain only zeros
 for qemu-img to create a sparse image during conversion. This value is rounded
 down to the nearest 512 bytes. You may use the common size suffixes like
-@code{k} for kilobytes.
+@code{k} for kilobytes. If this option is used, copy offloading will not be
+attempted.
 
 @item -t @var{cache}
 specifies the cache mode that should be used with the (destination) file. See
-- 
2.13.6

  parent reply	other threads:[~2018-07-12 16:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 16:31 [Qemu-devel] [PULL 0/7] Block layer fixes for 3.0-rc1 Kevin Wolf
2018-07-12 16:31 ` [Qemu-devel] [PULL 1/7] iotests: 153: Fix dead code Kevin Wolf
2018-07-12 16:31 ` [Qemu-devel] [PULL 2/7] iotests: nbd: Stop qemu-nbd before remaking image Kevin Wolf
2018-07-12 16:31 ` Kevin Wolf [this message]
2018-07-12 16:31 ` [Qemu-devel] [PULL 4/7] file-posix: specify expected filetypes Kevin Wolf
2018-07-12 16:31 ` [Qemu-devel] [PULL 5/7] iotests: add test 226 for file driver types Kevin Wolf
2018-07-12 16:31 ` [Qemu-devel] [PULL 6/7] scsi-disk: Block Device Characteristics emulation fix Kevin Wolf
2018-07-12 16:31 ` [Qemu-devel] [PULL 7/7] qemu-img: align result of is_allocated_sectors Kevin Wolf
2018-07-12 17:24 ` [Qemu-devel] [PULL 0/7] Block layer fixes for 3.0-rc1 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180712163152.12521-4-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).