From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fdsCp-0003LR-Vc for qemu-devel@nongnu.org; Fri, 13 Jul 2018 03:09:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fdsCo-00051X-Vz for qemu-devel@nongnu.org; Fri, 13 Jul 2018 03:09:31 -0400 Date: Fri, 13 Jul 2018 09:09:20 +0200 From: Kevin Wolf Message-ID: <20180713070920.GA3896@localhost.localdomain> References: <20180712221208.3732-1-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180712221208.3732-1-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Max Reitz Am 13.07.2018 um 00:12 hat John Snow geschrieben: > This test doesn't actually care about the format anyway, it just > supports "all formats" as a convenience. LUKS however does not use a > simple image filename which confuses this iotest. > > We can simply remove the LUKS "support" and be happier for it. > > Signed-off-by: John Snow > --- > tests/qemu-iotests/226 | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226 > index 460aea2fc9..ebfaf62e53 100755 > --- a/tests/qemu-iotests/226 > +++ b/tests/qemu-iotests/226 > @@ -40,7 +40,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > . ./common.pattern > > # Generic format, but tests file-protocol specific error handling > +# LUKS does not use a simple filename; this test doesn't use the format anyway. > _supported_fmt generic > +_unsupported_fmt luks > _supported_proto file > _supported_os Linux Maybe it would be better to test for $IMGOPTSSYNTAX = "true", because that's the real problem here? Kevin