* [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226
@ 2018-07-12 22:12 John Snow
2018-07-13 7:09 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: John Snow @ 2018-07-12 22:12 UTC (permalink / raw)
To: qemu-block, qemu-devel; +Cc: Kevin Wolf, Max Reitz, John Snow
This test doesn't actually care about the format anyway, it just
supports "all formats" as a convenience. LUKS however does not use a
simple image filename which confuses this iotest.
We can simply remove the LUKS "support" and be happier for it.
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/qemu-iotests/226 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226
index 460aea2fc9..ebfaf62e53 100755
--- a/tests/qemu-iotests/226
+++ b/tests/qemu-iotests/226
@@ -40,7 +40,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
. ./common.pattern
# Generic format, but tests file-protocol specific error handling
+# LUKS does not use a simple filename; this test doesn't use the format anyway.
_supported_fmt generic
+_unsupported_fmt luks
_supported_proto file
_supported_os Linux
--
2.14.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226
2018-07-12 22:12 [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226 John Snow
@ 2018-07-13 7:09 ` Kevin Wolf
2018-07-13 17:06 ` John Snow
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Wolf @ 2018-07-13 7:09 UTC (permalink / raw)
To: John Snow; +Cc: qemu-block, qemu-devel, Max Reitz
Am 13.07.2018 um 00:12 hat John Snow geschrieben:
> This test doesn't actually care about the format anyway, it just
> supports "all formats" as a convenience. LUKS however does not use a
> simple image filename which confuses this iotest.
>
> We can simply remove the LUKS "support" and be happier for it.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/226 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226
> index 460aea2fc9..ebfaf62e53 100755
> --- a/tests/qemu-iotests/226
> +++ b/tests/qemu-iotests/226
> @@ -40,7 +40,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> . ./common.pattern
>
> # Generic format, but tests file-protocol specific error handling
> +# LUKS does not use a simple filename; this test doesn't use the format anyway.
> _supported_fmt generic
> +_unsupported_fmt luks
> _supported_proto file
> _supported_os Linux
Maybe it would be better to test for $IMGOPTSSYNTAX = "true", because
that's the real problem here?
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226
2018-07-13 7:09 ` Kevin Wolf
@ 2018-07-13 17:06 ` John Snow
0 siblings, 0 replies; 3+ messages in thread
From: John Snow @ 2018-07-13 17:06 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-block, qemu-devel, Max Reitz
On 07/13/2018 03:09 AM, Kevin Wolf wrote:
> Am 13.07.2018 um 00:12 hat John Snow geschrieben:
>> This test doesn't actually care about the format anyway, it just
>> supports "all formats" as a convenience. LUKS however does not use a
>> simple image filename which confuses this iotest.
>>
>> We can simply remove the LUKS "support" and be happier for it.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> tests/qemu-iotests/226 | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226
>> index 460aea2fc9..ebfaf62e53 100755
>> --- a/tests/qemu-iotests/226
>> +++ b/tests/qemu-iotests/226
>> @@ -40,7 +40,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>> . ./common.pattern
>>
>> # Generic format, but tests file-protocol specific error handling
>> +# LUKS does not use a simple filename; this test doesn't use the format anyway.
>> _supported_fmt generic
>> +_unsupported_fmt luks
>> _supported_proto file
>> _supported_os Linux
>
> Maybe it would be better to test for $IMGOPTSSYNTAX = "true", because
> that's the real problem here?
>
> Kevin
>
Oh, OK. I didn't know about that var.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-13 17:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-12 22:12 [Qemu-devel] [PATCH] iotests: remove LUKS support from test 226 John Snow
2018-07-13 7:09 ` Kevin Wolf
2018-07-13 17:06 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).