From: "Alex Bennée" <alex.bennee@linaro.org>
To: cota@braap.org, famz@redhat.com, berrange@redhat.com,
f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com,
aurelien@aurel32.net, agraf@suse.de
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v2 for 3.0 13/16] docker: add --hint to docker.py check
Date: Fri, 13 Jul 2018 13:17:38 +0100 [thread overview]
Message-ID: <20180713121741.19262-14-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180713121741.19262-1-alex.bennee@linaro.org>
When a check fails we currently just report why we failed. This is not
totally helpful to people who want to boot-strap a new image. Add a
--hint option which we can pass down to give a bit more information.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/docker/Makefile.include | 3 ++-
tests/docker/docker.py | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index ec23620153..c9e412f9d0 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -73,7 +73,8 @@ docker-binfmt-image-debian-%: $(DOCKER_FILES_DIR)/debian-bootstrap.docker
$(if $(EXECUTABLE),--include-executable=$(EXECUTABLE)), \
"BUILD","binfmt debian-$* (debootstrapped)"), \
$(call quiet-command, \
- $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $<, \
+ $(DOCKER_SCRIPT) check --quiet qemu:debian-$* $< \
+ --hint "you will need to build $(EXECUTABLE)", \
"CHECK", "debian-$* exists"))
endif
diff --git a/tests/docker/docker.py b/tests/docker/docker.py
index 2f81c6b13b..523f4b95a2 100755
--- a/tests/docker/docker.py
+++ b/tests/docker/docker.py
@@ -475,6 +475,7 @@ class CheckCommand(SubCommand):
default="checksum", help="check type")
parser.add_argument("--olderthan", default=60, type=int,
help="number of minutes")
+ parser.add_argument("--hint", default="", help="hint to user")
def run(self, args, argv):
tag = args.tag
@@ -487,7 +488,7 @@ class CheckCommand(SubCommand):
info = dkr.inspect_tag(tag)
if info is None:
- print("Image does not exist")
+ print("Image does not exist %s" % (args.hint))
return 1
if args.checktype == "checksum":
--
2.17.1
next prev parent reply other threads:[~2018-07-13 12:17 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 12:17 [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 01/16] tests/.gitignore: don't ignore docker tests Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 02/16] docker: base debian-tricore on qemu:debian9 Alex Bennée
2018-07-17 14:49 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 03/16] shippable: Build the TriCore docker image Alex Bennée
2018-07-13 13:27 ` Alex Bennée
2018-07-17 2:55 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 04/16] docker: fail more gracefully on docker.py check Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 05/16] docker: split configure_qemu from build_qemu Alex Bennée
2018-07-17 2:50 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 06/16] docker: move make check into check_qemu helper Alex Bennée
2018-07-17 3:00 ` Philippe Mathieu-Daudé
2018-07-17 9:59 ` Alex Bennée
2018-07-17 14:56 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 07/16] docker: gracefully skip check_qemu Alex Bennée
2018-07-17 3:02 ` Philippe Mathieu-Daudé
2018-07-17 10:22 ` Alex Bennée
2018-07-17 15:05 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 08/16] docker: Makefile.include don't include partial images Alex Bennée
2018-07-17 3:07 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 09/16] docker: disable debian-powerpc-user-cross Alex Bennée
2018-07-17 15:52 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 10/16] docker: add test-unit runner Alex Bennée
2018-07-17 3:37 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 11/16] docker: add expansion for docker-test-FOO to Makefile.include Alex Bennée
2018-07-16 1:42 ` Philippe Mathieu-Daudé
2018-07-16 9:07 ` Alex Bennée
2018-07-17 15:03 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 12/16] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set Alex Bennée
2018-07-17 15:51 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` Alex Bennée [this message]
2018-07-17 3:24 ` [Qemu-devel] [PATCH v2 for 3.0 13/16] docker: add --hint to docker.py check Philippe Mathieu-Daudé
2018-07-17 15:14 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 14/16] docker: Update debootstrap script after Debian migration from Alioth to Salsa Alex Bennée
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 15/16] docker: add commentary to debian-bootstrap.docker Alex Bennée
2018-07-17 15:02 ` Philippe Mathieu-Daudé
2018-07-13 12:17 ` [Qemu-devel] [PATCH v2 for 3.0 16/16] docker: ignore distro versioning of debootstrap Alex Bennée
2018-07-17 15:52 ` Philippe Mathieu-Daudé
2018-07-17 16:02 ` [Qemu-devel] [PATCH v2 for 3.0 00/16] various docker fixes Philippe Mathieu-Daudé
2018-07-17 18:53 ` Alex Bennée
2018-07-17 20:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713121741.19262-14-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=balrogg@gmail.com \
--cc=berrange@redhat.com \
--cc=cota@braap.org \
--cc=f4bug@amsat.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).