From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fe18M-0000SF-WA for qemu-devel@nongnu.org; Fri, 13 Jul 2018 12:41:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fe18M-0003sf-99 for qemu-devel@nongnu.org; Fri, 13 Jul 2018 12:41:31 -0400 Date: Fri, 13 Jul 2018 12:41:21 -0400 From: "Emilio G. Cota" Message-ID: <20180713164121.GA22074@flamenco> References: <20180710160013.26559-1-peter.maydell@linaro.org> <20180710160013.26559-5-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180710160013.26559-5-peter.maydell@linaro.org> Subject: Re: [Qemu-devel] [PATCH 4/6] accel/tcg: tb_gen_code(): Create single-insn TB for execution from non-RAM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, patches@linaro.org, Richard Henderson , Paolo Bonzini , =?iso-8859-1?Q?C=E9dric?= Le Goater , "Edgar E. Iglesias" , KONRAD Frederic On Tue, Jul 10, 2018 at 17:00:11 +0100, Peter Maydell wrote: > If get_page_addr_code() returns -1, this indicates that there is no RAM > page we can read a full TB from. Instead we must create a TB which > contains a single instruction and which we do not cache, so it is > executed only once. > > Since this means we can now have TBs which are not in any page list, > we also need to make tb_phys_invalidate() handle them (by not trying > to remove them from a nonexistent page list). > > Signed-off-by: Peter Maydell Reviewed-by: Emilio G. Cota Emilio