* [Qemu-devel] [PATCH v2] iotests: remove LUKS support from test 226
@ 2018-07-13 17:37 John Snow
2018-07-23 13:51 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: John Snow @ 2018-07-13 17:37 UTC (permalink / raw)
To: qemu-block, qemu-devel; +Cc: kwolf, Max Reitz, John Snow
This test doesn't actually care about the format anyway, it just
supports "all formats" as a convenience. LUKS however does not use a
simple image filename which confuses this iotest.
We can simply skip the test for formats that use IMGOPTSSYNTAX for
their filenames without missing much coverage.
Signed-off-by: John Snow <jsnow@redhat.com>
---
V2: Test against IMGOPTSSYNTAX instead of 'luks' directly (Kevin)
tests/qemu-iotests/226 | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/226 b/tests/qemu-iotests/226
index 460aea2fc9..34987d43f9 100755
--- a/tests/qemu-iotests/226
+++ b/tests/qemu-iotests/226
@@ -41,6 +41,9 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
# Generic format, but tests file-protocol specific error handling
_supported_fmt generic
+if [ "$IMGOPTSSYNTAX" = "true" ]; then
+ _unsupported_fmt $IMGFMT
+fi
_supported_proto file
_supported_os Linux
--
2.14.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] iotests: remove LUKS support from test 226
2018-07-13 17:37 [Qemu-devel] [PATCH v2] iotests: remove LUKS support from test 226 John Snow
@ 2018-07-23 13:51 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2018-07-23 13:51 UTC (permalink / raw)
To: John Snow; +Cc: qemu-block, qemu-devel, Max Reitz
Am 13.07.2018 um 19:37 hat John Snow geschrieben:
> This test doesn't actually care about the format anyway, it just
> supports "all formats" as a convenience. LUKS however does not use a
> simple image filename which confuses this iotest.
>
> We can simply skip the test for formats that use IMGOPTSSYNTAX for
> their filenames without missing much coverage.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-23 13:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-13 17:37 [Qemu-devel] [PATCH v2] iotests: remove LUKS support from test 226 John Snow
2018-07-23 13:51 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).