From: Eduardo Habkost <ehabkost@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-arm@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Beniamino Galvani <b.galvani@gmail.com>,
Subbaraya Sundeep <sundeep.lkml@gmail.com>,
Alistair Francis <alistair@alistair23.me>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 01/16] qom/object: Add a new function object_initialize_child()
Date: Fri, 13 Jul 2018 18:46:54 -0300 [thread overview]
Message-ID: <20180713214654.GW31657@localhost.localdomain> (raw)
In-Reply-To: <0a63f154-ac68-b6f0-ab6a-e0951c6ae8d5@suse.de>
On Fri, Jul 13, 2018 at 11:29:17PM +0200, Andreas Färber wrote:
> Am 13.07.2018 um 23:16 schrieb Eduardo Habkost:
> > I wonder if we should deprecate object_initialize() and support
> > only object_initialize_child() later. Initializing an object
> > contained inside another one without making it a child of the
> > parent object is a recipe for trouble.
>
> The root container object needs to be initialized, too.
If the object is not embedded in another struct, I would expect
it to be created using object_new() instead of
object_initialize().
--
Eduardo
next prev parent reply other threads:[~2018-07-13 21:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 8:27 [Qemu-devel] [PATCH v2 00/16] Fix crashes with introspection of ARM devices Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 01/16] qom/object: Add a new function object_initialize_child() Thomas Huth
2018-07-13 11:14 ` Paolo Bonzini
2018-07-13 21:16 ` Eduardo Habkost
2018-07-13 21:29 ` Andreas Färber
2018-07-13 21:46 ` Eduardo Habkost [this message]
2018-07-16 7:05 ` Thomas Huth
2018-07-13 22:57 ` Eduardo Habkost
2018-07-16 7:16 ` Thomas Huth
2018-08-16 11:59 ` Thomas Huth
2018-08-17 1:40 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 02/16] hw/core/sysbus: Add a function for creating and attaching an object Thomas Huth
2018-07-13 21:17 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 03/16] hw/arm/bcm2836: Fix crash with device_add bcm2837 on unsupported machines Thomas Huth
2018-07-13 21:26 ` Eduardo Habkost
2018-07-16 7:09 ` Thomas Huth
2018-07-16 19:48 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 04/16] hw/arm/armv7: Fix crash when introspecting the "iotkit" device Thomas Huth
2018-07-13 21:31 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 05/16] hw/cpu/a15mpcore: Fix introspection problem with the a15mpcore_priv device Thomas Huth
2018-07-13 21:48 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 06/16] hw/display/xlnx_dp: Move problematic code from instance_init to realize Thomas Huth
2018-07-13 11:13 ` Paolo Bonzini
2018-07-13 15:59 ` Thomas Huth
2018-07-13 17:13 ` Paolo Bonzini
2018-07-16 11:34 ` Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 07/16] hw/arm/xlnx-zynqmp: Fix crash when introspecting the "xlnx, zynqmp" device Thomas Huth
2018-07-13 21:49 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 08/16] hw/arm/msf2-soc: Fix introspection problem with the "msf2-soc" device Thomas Huth
2018-07-13 21:53 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 09/16] hw/cpu/a9mpcore: Fix introspection problems with the "a9mpcore_priv" device Thomas Huth
2018-07-13 21:53 ` Eduardo Habkost
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 10/16] hw/arm/fsl-imx6: Fix introspection problems with the "fsl, imx6" device Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 11/16] hw/arm/fsl-imx7: Fix introspection problems with the "fsl, imx7" device Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 12/16] hw/arm/fsl-imx25: Fix introspection problem with the "fsl, imx25" device Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 13/16] hw/arm/fsl-imx31: Fix introspection problem with the "fsl, imx31" device Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 14/16] hw/cpu/arm11mpcore: Fix introspection problem with 'arm11mpcore_priv' Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 15/16] hw/*/realview: Fix introspection problem with 'realview_mpcore' & 'realview_gic' Thomas Huth
2018-07-13 8:27 ` [Qemu-devel] [PATCH v2 16/16] hw/arm/allwinner-a10: Fix introspection problem with 'allwinner-a10' Thomas Huth
2018-07-13 10:56 ` [Qemu-devel] [PATCH v2 00/16] Fix crashes with introspection of ARM devices Richard Henderson
2018-07-13 22:00 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713214654.GW31657@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=alistair@alistair23.me \
--cc=armbru@redhat.com \
--cc=b.galvani@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sundeep.lkml@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).