* [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code
@ 2018-07-15 20:59 BALATON Zoltan
2018-07-15 22:19 ` Philippe Mathieu-Daudé
2018-07-16 1:19 ` David Gibson
0 siblings, 2 replies; 3+ messages in thread
From: BALATON Zoltan @ 2018-07-15 20:59 UTC (permalink / raw)
To: qemu-devel; +Cc: David Gibson, Paolo Bonzini
Coverity warned that the false arm of conditional expression is
unreachable when it is inside an if with the same condition.
Remove the unreachable code to avoid the warning.
Fixes: CID 1394215
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/display/sm501.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 9ab29d3..874260a 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -1024,7 +1024,7 @@ static void sm501_i2c_write(void *opaque, hwaddr addr, uint64_t value,
if (res) {
SM501_DPRINTF("sm501 i2c : transfer failed"
" i=%d, res=%d\n", i, res);
- s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR : 0);
+ s->i2c_status |= SM501_I2C_STATUS_ERROR;
return;
}
}
--
2.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code
2018-07-15 20:59 [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code BALATON Zoltan
@ 2018-07-15 22:19 ` Philippe Mathieu-Daudé
2018-07-16 1:19 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-07-15 22:19 UTC (permalink / raw)
To: BALATON Zoltan, qemu-devel; +Cc: Paolo Bonzini, David Gibson
On 07/15/2018 05:59 PM, BALATON Zoltan wrote:
> Coverity warned that the false arm of conditional expression is
> unreachable when it is inside an if with the same condition.
> Remove the unreachable code to avoid the warning.
>
> Fixes: CID 1394215
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 9ab29d3..874260a 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1024,7 +1024,7 @@ static void sm501_i2c_write(void *opaque, hwaddr addr, uint64_t value,
> if (res) {
> SM501_DPRINTF("sm501 i2c : transfer failed"
> " i=%d, res=%d\n", i, res);
> - s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR : 0);
> + s->i2c_status |= SM501_I2C_STATUS_ERROR;
> return;
> }
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code
2018-07-15 20:59 [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code BALATON Zoltan
2018-07-15 22:19 ` Philippe Mathieu-Daudé
@ 2018-07-16 1:19 ` David Gibson
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2018-07-16 1:19 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-devel, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
On Sun, Jul 15, 2018 at 10:59:21PM +0200, BALATON Zoltan wrote:
> Coverity warned that the false arm of conditional expression is
> unreachable when it is inside an if with the same condition.
> Remove the unreachable code to avoid the warning.
>
> Fixes: CID 1394215
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
Applied to ppc-for-3.0, thanks.
> ---
> hw/display/sm501.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 9ab29d3..874260a 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1024,7 +1024,7 @@ static void sm501_i2c_write(void *opaque, hwaddr addr, uint64_t value,
> if (res) {
> SM501_DPRINTF("sm501 i2c : transfer failed"
> " i=%d, res=%d\n", i, res);
> - s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR : 0);
> + s->i2c_status |= SM501_I2C_STATUS_ERROR;
> return;
> }
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-16 1:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-15 20:59 [Qemu-devel] [PATCH for 3.0] sm501: Fix warning about unreachable code BALATON Zoltan
2018-07-15 22:19 ` Philippe Mathieu-Daudé
2018-07-16 1:19 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).