* [Qemu-devel] [PATCH] tests: vm: Add vm-clean-all
@ 2018-07-16 2:00 Fam Zheng
2018-07-17 2:54 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Fam Zheng @ 2018-07-16 2:00 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Alex Bennée, Philippe Mathieu-Daudé
The images are big. Add a rule to clean up easily.
Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/vm/Makefile.include | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index 5daa2a3b73..79e7866c8b 100644
--- a/tests/vm/Makefile.include
+++ b/tests/vm/Makefile.include
@@ -1,6 +1,6 @@
# Makefile for VM tests
-.PHONY: vm-build-all
+.PHONY: vm-build-all vm-clean-all
IMAGES := ubuntu.i386 freebsd netbsd openbsd
IMAGE_FILES := $(patsubst %, tests/vm/%.img, $(IMAGES))
@@ -17,6 +17,9 @@ vm-test:
vm-build-all: $(addprefix vm-build-, $(IMAGES))
+vm-clean-all:
+ rm -f $(IMAGE_FILES)
+
tests/vm/%.img: $(SRC_PATH)/tests/vm/% \
$(SRC_PATH)/tests/vm/basevm.py \
$(SRC_PATH)/tests/vm/Makefile.include
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: vm: Add vm-clean-all
2018-07-16 2:00 [Qemu-devel] [PATCH] tests: vm: Add vm-clean-all Fam Zheng
@ 2018-07-17 2:54 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-07-17 2:54 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Alex Bennée
On 07/15/2018 11:00 PM, Fam Zheng wrote:
> The images are big. Add a rule to clean up easily.
Thanks :)
>
> Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/vm/Makefile.include | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
> index 5daa2a3b73..79e7866c8b 100644
> --- a/tests/vm/Makefile.include
> +++ b/tests/vm/Makefile.include
> @@ -1,6 +1,6 @@
> # Makefile for VM tests
>
> -.PHONY: vm-build-all
> +.PHONY: vm-build-all vm-clean-all
Just noticed none of those are in the "vm-test" help message.
>
> IMAGES := ubuntu.i386 freebsd netbsd openbsd
> IMAGE_FILES := $(patsubst %, tests/vm/%.img, $(IMAGES))
> @@ -17,6 +17,9 @@ vm-test:
>
> vm-build-all: $(addprefix vm-build-, $(IMAGES))
>
> +vm-clean-all:
> + rm -f $(IMAGE_FILES)
> +
> tests/vm/%.img: $(SRC_PATH)/tests/vm/% \
> $(SRC_PATH)/tests/vm/basevm.py \
> $(SRC_PATH)/tests/vm/Makefile.include
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-17 2:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-16 2:00 [Qemu-devel] [PATCH] tests: vm: Add vm-clean-all Fam Zheng
2018-07-17 2:54 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).