From: Eduardo Habkost <ehabkost@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Babu Moger <babu.moger@amd.com>,
mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com,
mtosatti@redhat.com, rth@twiddle.net, geoff@hostfission.com,
kash@tripleback.net, qemu-devel@nongnu.org,
Aleksandar Markovic <aleksandar.markovic@rt-rk.com>,
aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently
Date: Mon, 16 Jul 2018 16:52:14 -0300 [thread overview]
Message-ID: <20180716195214.GN31657@localhost.localdomain> (raw)
In-Reply-To: <42cdb351-425b-edd2-a4b2-c8e5ffeeec76@amsat.org>
On Mon, Jul 16, 2018 at 10:20:09AM -0300, Philippe Mathieu-Daudé wrote:
[...]
> > +enum CacheType {
> > + DCACHE,
>
> I just noticed this clashes on mips host:
[...]
> In file included from /usr/include/mips-linux-gnu/sys/cachectl.h:26:0,
> from /tmp/qemu-test/src/tcg/mips/tcg-target.h:202,
> from /tmp/qemu-test/src/include/exec/cpu-defs.h:29,
> from /tmp/qemu-test/src/target/i386/cpu.h:34,
> from /tmp/qemu-test/src/exec.c:23:
> /tmp/qemu-test/src/target/i386/cpu.h:1053:5: error: expected identifier
> before '(' token
> DCACHE,
> ^
Oops. I will take a look and submit a fix. Thanks for the
report!
--
Eduardo
next prev parent reply other threads:[~2018-07-16 19:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 20:41 [Qemu-devel] [PATCH v8 0/8] i386: Enable TOPOEXT to support hyperthreading on AMD CPU Babu Moger
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently Babu Moger
2018-05-11 19:12 ` Eduardo Habkost
2018-07-16 13:20 ` Philippe Mathieu-Daudé
2018-07-16 19:52 ` Eduardo Habkost [this message]
2018-07-17 15:42 ` Philippe Mathieu-Daudé
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 2/8] i386: Add cache information in X86CPUDefinition Babu Moger
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 3/8] i386: Add new property to control cache info Babu Moger
2018-05-11 19:21 ` Eduardo Habkost
2018-05-11 20:21 ` Moger, Babu
2018-05-11 20:40 ` Eduardo Habkost
2018-05-11 20:47 ` Eduardo Habkost
2018-05-14 16:44 ` Moger, Babu
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 4/8] i386: Initialize cache information for EPYC family processors Babu Moger
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 5/8] i386: Populate AMD Processor Cache Information for cpuid 0x8000001D Babu Moger
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 6/8] i386: Add support for CPUID_8000_001E for AMD Babu Moger
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 7/8] i386: Enable TOPOEXT feature on AMD EPYC CPU Babu Moger
2018-05-11 20:46 ` Eduardo Habkost
2018-05-11 22:16 ` Moger, Babu
2018-05-10 20:41 ` [Qemu-devel] [PATCH v8 8/8] i386: Remove generic SMT thread check Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716195214.GN31657@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=aleksandar.markovic@rt-rk.com \
--cc=aurelien@aurel32.net \
--cc=babu.moger@amd.com \
--cc=f4bug@amsat.org \
--cc=geoff@hostfission.com \
--cc=kash@tripleback.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).