From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, "Fam Zheng" <famz@redhat.com>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/5] tests/vm: Extract the kvm_available() handy function
Date: Mon, 16 Jul 2018 23:48:23 -0300 [thread overview]
Message-ID: <20180717024827.27897-2-f4bug@amsat.org> (raw)
In-Reply-To: <20180717024827.27897-1-f4bug@amsat.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
tests/vm/basevm.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py
index 3643117816..04089cd545 100755
--- a/tests/vm/basevm.py
+++ b/tests/vm/basevm.py
@@ -33,6 +33,11 @@ SSH_KEY = open(os.path.join(os.path.dirname(__file__),
SSH_PUB_KEY = open(os.path.join(os.path.dirname(__file__),
"..", "keys", "id_rsa.pub")).read()
+
+def kvm_available():
+ return os.access("/dev/kvm", os.R_OK | os.W_OK)
+
+
class BaseVM(object):
GUEST_USER = "qemu"
GUEST_PASS = "qemupass"
@@ -72,7 +77,7 @@ class BaseVM(object):
"-serial", "file:%s" % os.path.join(self._tmpdir, "serial.out")]
if vcpus:
self._args += ["-smp", str(vcpus)]
- if os.access("/dev/kvm", os.R_OK | os.W_OK):
+ if kvm_available():
self._args += ["-enable-kvm"]
else:
logging.info("KVM not available, not using -enable-kvm")
--
2.18.0
next prev parent reply other threads:[~2018-07-17 2:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 2:48 [Qemu-devel] [PATCH 0/5] tests/vm: Improvements when KVM is not available Philippe Mathieu-Daudé
2018-07-17 2:48 ` Philippe Mathieu-Daudé [this message]
2018-07-17 2:48 ` [Qemu-devel] [PATCH 2/5] tests/vm: Use 'host' cpu when KVM is available, else default to 'max' Philippe Mathieu-Daudé
2018-07-17 2:48 ` [Qemu-devel] [PATCH 3/5] tests/vm: Do not abuse parallelism when KVM is not available Philippe Mathieu-Daudé
2018-07-17 13:37 ` Fam Zheng
2018-07-17 2:48 ` [Qemu-devel] [RFC PATCH 4/5] tests/vm: Display remaining seconds to wait for a VM to start Philippe Mathieu-Daudé
2018-07-17 2:48 ` [Qemu-devel] [RFC PATCH 5/5] tests/vm: When using TCG, wait longer " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717024827.27897-2-f4bug@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).