From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, famz@redhat.com,
amit@kernel.org, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH for 3.1 2/4] virtio: Check qemu_get_virtqueue_element returns
Date: Tue, 17 Jul 2018 11:30:42 +0100 [thread overview]
Message-ID: <20180717103042.GA9927@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180716173743.133393-3-dgilbert@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 479 bytes --]
On Mon, Jul 16, 2018 at 06:37:41PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Check calls to qemu_get_virtqueue_element for NULL and pass
> up the chain.
What happens to the device state that has been partially deserialized
(e.g. virtio-blk's s->rq linked list)?
It's not clear to me that simply returning NULL is enough to put QEMU
into a sane state without memory leaks or crashes if we decide to retry.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-07-17 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 17:37 [Qemu-devel] [PATCH for 3.1 0/4] virtio migration load path Dr. David Alan Gilbert (git)
2018-07-16 17:37 ` [Qemu-devel] [PATCH for 3.1 1/4] scsi/migration: Allow bus load request to fail Dr. David Alan Gilbert (git)
2018-07-17 9:08 ` Cornelia Huck
2018-07-16 17:37 ` [Qemu-devel] [PATCH for 3.1 2/4] virtio: Check qemu_get_virtqueue_element returns Dr. David Alan Gilbert (git)
2018-07-17 9:11 ` Cornelia Huck
2018-07-17 10:30 ` Stefan Hajnoczi [this message]
2018-07-16 17:37 ` [Qemu-devel] [PATCH for 3.1 3/4] virtio-scsi/migration: Allow load_request to fail Dr. David Alan Gilbert (git)
2018-07-17 9:13 ` Cornelia Huck
2018-07-16 17:37 ` [Qemu-devel] [PATCH for 3.1 4/4] virtio: qemu_get_virtqueue_element fail rather than assert Dr. David Alan Gilbert (git)
2018-07-17 9:16 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717103042.GA9927@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=amit@kernel.org \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).