From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: [Qemu-devel] Why do we typedef every struct on QEMU?
Date: Tue, 17 Jul 2018 16:50:28 -0300 [thread overview]
Message-ID: <20180717195028.GA6691@localhost.localdomain> (raw)
I have been looking at patches that touch typedefs.h and
wondering: why do we make typedefs.h necessary at all? Why do we
always add typedefs for every struct and union type in QEMU?
Why do we prefer to write this:
----- qemu/typedefs.h:
typedef struct SomeType SomeType;
----------------------
----- qemu/somecode.h:
#include <qemu/typedefs.h>
int some_function(SomeType *a);
----------------------
...instead of simply writing this:?
----- qemu/somecode.h:
struct SomeType;
int some_function(struct SomeType *a);
----------------------
Is the maintenance burden of typedefs.h worth it?
--
Eduardo
next reply other threads:[~2018-07-17 19:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 19:50 Eduardo Habkost [this message]
2018-07-17 20:06 ` [Qemu-devel] Why do we typedef every struct on QEMU? Peter Maydell
2018-07-19 6:42 ` Markus Armbruster
2018-07-19 8:18 ` Thomas Huth
2018-07-19 8:28 ` Paolo Bonzini
2018-07-27 13:03 ` Stefan Hajnoczi
2018-07-27 13:14 ` Daniel P. Berrangé
2018-07-27 13:16 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717195028.GA6691@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=f4bug@amsat.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).