From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [Qemu-devel] [RFC PATCH 1/3] balloon: Allow nested inhibits
Date: Tue, 17 Jul 2018 16:47:37 -0600 [thread overview]
Message-ID: <20180717224737.14019.3324.stgit@gimli.home> (raw)
In-Reply-To: <20180717222721.14019.27548.stgit@gimli.home>
A simple true/false internal state does not allow multiple users. Fix
this within the existing interface by converting to a counter, so long
as the counter is elevated, ballooning is inhibited.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
balloon.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/balloon.c b/balloon.c
index 6bf0a9681377..2a6a7e1a22a0 100644
--- a/balloon.c
+++ b/balloon.c
@@ -37,16 +37,17 @@
static QEMUBalloonEvent *balloon_event_fn;
static QEMUBalloonStatus *balloon_stat_fn;
static void *balloon_opaque;
-static bool balloon_inhibited;
+static int balloon_inhibited;
bool qemu_balloon_is_inhibited(void)
{
- return balloon_inhibited;
+ return balloon_inhibited > 0;
}
void qemu_balloon_inhibit(bool state)
{
- balloon_inhibited = state;
+ balloon_inhibited += (state ? 1 : -1);
+ assert(balloon_inhibited >= 0);
}
static bool have_balloon(Error **errp)
next prev parent reply other threads:[~2018-07-17 22:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:47 [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements Alex Williamson
2018-07-17 22:47 ` Alex Williamson [this message]
2018-07-18 6:40 ` [Qemu-devel] [RFC PATCH 1/3] balloon: Allow nested inhibits Peter Xu
2018-07-18 16:37 ` Alex Williamson
2018-07-19 4:45 ` Peter Xu
2018-07-17 22:47 ` [Qemu-devel] [RFC PATCH 2/3] kvm: Use inhibit to prevent ballooning without synchronous mmu Alex Williamson
2018-07-17 22:47 ` [Qemu-devel] [RFC PATCH 3/3] vfio: Inhibit ballooning Alex Williamson
2018-07-18 6:48 ` [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements Peter Xu
2018-07-18 9:36 ` Cornelia Huck
2018-07-19 4:49 ` Peter Xu
2018-07-19 8:42 ` Cornelia Huck
2018-07-19 9:30 ` Peter Xu
2018-07-19 15:31 ` Alex Williamson
2018-07-18 16:31 ` Alex Williamson
2018-07-19 5:40 ` Peter Xu
2018-07-19 15:01 ` Alex Williamson
2018-07-20 2:56 ` Peter Xu
2018-07-30 13:34 ` Michael S. Tsirkin
2018-07-30 13:54 ` David Hildenbrand
2018-07-30 13:59 ` Michael S. Tsirkin
2018-07-30 14:46 ` David Hildenbrand
2018-07-30 14:58 ` Michael S. Tsirkin
2018-07-30 15:05 ` David Hildenbrand
2018-07-30 14:39 ` Alex Williamson
2018-07-30 14:51 ` Michael S. Tsirkin
2018-07-30 15:01 ` Alex Williamson
2018-07-30 15:49 ` Michael S. Tsirkin
2018-07-30 16:42 ` Alex Williamson
2018-07-30 17:35 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717224737.14019.3324.stgit@gimli.home \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).