From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [Qemu-devel] [RFC PATCH 2/3] kvm: Use inhibit to prevent ballooning without synchronous mmu
Date: Tue, 17 Jul 2018 16:47:45 -0600 [thread overview]
Message-ID: <20180717224745.14019.33974.stgit@gimli.home> (raw)
In-Reply-To: <20180717222721.14019.27548.stgit@gimli.home>
Remove KVM specific tests in balloon_page(), instead marking
ballooning as inhibited without KVM_CAP_SYNC_MMU support.
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
accel/kvm/kvm-all.c | 4 ++++
hw/virtio/virtio-balloon.c | 4 +---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index eb7db92a5e3b..38f468d8e2b1 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -39,6 +39,7 @@
#include "trace.h"
#include "hw/irq.h"
#include "sysemu/sev.h"
+#include "sysemu/balloon.h"
#include "hw/boards.h"
@@ -1698,6 +1699,9 @@ static int kvm_init(MachineState *ms)
s->many_ioeventfds = kvm_check_many_ioeventfds();
s->sync_mmu = !!kvm_vm_check_extension(kvm_state, KVM_CAP_SYNC_MMU);
+ if (!s->sync_mmu) {
+ qemu_balloon_inhibit(true);
+ }
return 0;
diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c
index 1f7a87f09429..b5425080c5fb 100644
--- a/hw/virtio/virtio-balloon.c
+++ b/hw/virtio/virtio-balloon.c
@@ -21,7 +21,6 @@
#include "hw/mem/pc-dimm.h"
#include "sysemu/balloon.h"
#include "hw/virtio/virtio-balloon.h"
-#include "sysemu/kvm.h"
#include "exec/address-spaces.h"
#include "qapi/error.h"
#include "qapi/qapi-events-misc.h"
@@ -36,8 +35,7 @@
static void balloon_page(void *addr, int deflate)
{
- if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
- kvm_has_sync_mmu())) {
+ if (!qemu_balloon_is_inhibited()) {
qemu_madvise(addr, BALLOON_PAGE_SIZE,
deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
}
next prev parent reply other threads:[~2018-07-17 22:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 22:47 [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements Alex Williamson
2018-07-17 22:47 ` [Qemu-devel] [RFC PATCH 1/3] balloon: Allow nested inhibits Alex Williamson
2018-07-18 6:40 ` Peter Xu
2018-07-18 16:37 ` Alex Williamson
2018-07-19 4:45 ` Peter Xu
2018-07-17 22:47 ` Alex Williamson [this message]
2018-07-17 22:47 ` [Qemu-devel] [RFC PATCH 3/3] vfio: Inhibit ballooning Alex Williamson
2018-07-18 6:48 ` [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements Peter Xu
2018-07-18 9:36 ` Cornelia Huck
2018-07-19 4:49 ` Peter Xu
2018-07-19 8:42 ` Cornelia Huck
2018-07-19 9:30 ` Peter Xu
2018-07-19 15:31 ` Alex Williamson
2018-07-18 16:31 ` Alex Williamson
2018-07-19 5:40 ` Peter Xu
2018-07-19 15:01 ` Alex Williamson
2018-07-20 2:56 ` Peter Xu
2018-07-30 13:34 ` Michael S. Tsirkin
2018-07-30 13:54 ` David Hildenbrand
2018-07-30 13:59 ` Michael S. Tsirkin
2018-07-30 14:46 ` David Hildenbrand
2018-07-30 14:58 ` Michael S. Tsirkin
2018-07-30 15:05 ` David Hildenbrand
2018-07-30 14:39 ` Alex Williamson
2018-07-30 14:51 ` Michael S. Tsirkin
2018-07-30 15:01 ` Alex Williamson
2018-07-30 15:49 ` Michael S. Tsirkin
2018-07-30 16:42 ` Alex Williamson
2018-07-30 17:35 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717224745.14019.33974.stgit@gimli.home \
--to=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).