From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH for 3.0 0/4] Multiple fixes and improvements to TLS tests
Date: Wed, 18 Jul 2018 10:38:11 +0100 [thread overview]
Message-ID: <20180718093815.8104-1-berrange@redhat.com> (raw)
The switch to enable TLS 1.3 protocol support in GNUTLS in Fedora
exposed a subtle flaw in our TLS unit tests. This was horrible to debug
because of bad error reporting in our tests which caused all the error
messages to be irretrievably lost instead of displayed on stderr.
Daniel P. Berrangé (4):
tests: call qcrypto_init instead of gnutls_global_init
tests: don't silence error reporting for all tests
tests: use error_abort in places expecting errors
tests: fix TLS handshake failure with TLS 1.3
stubs/error-printf.c | 5 +-
tests/crypto-tls-x509-helpers.c | 4 +-
tests/test-crypto-tlscredsx509.c | 11 +----
tests/test-crypto-tlssession.c | 80 ++++++++++++--------------------
tests/test-io-channel-tls.c | 24 ++++------
tests/test-vmstate.c | 3 ++
6 files changed, 51 insertions(+), 76 deletions(-)
--
2.17.1
next reply other threads:[~2018-07-18 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 9:38 Daniel P. Berrangé [this message]
2018-07-18 9:38 ` [Qemu-devel] [PATCH for 3.0 1/4] tests: call qcrypto_init instead of gnutls_global_init Daniel P. Berrangé
2018-07-18 13:41 ` Philippe Mathieu-Daudé
2018-07-18 9:38 ` [Qemu-devel] [PATCH for 3.0 2/4] tests: don't silence error reporting for all tests Daniel P. Berrangé
2018-07-18 13:44 ` Philippe Mathieu-Daudé
2018-07-24 16:35 ` Daniel P. Berrangé
2018-07-18 9:38 ` [Qemu-devel] [PATCH for 3.0 3/4] tests: use error_abort in places expecting errors Daniel P. Berrangé
2018-07-18 13:47 ` Philippe Mathieu-Daudé
2018-07-18 9:38 ` [Qemu-devel] [PATCH for 3.0 4/4] tests: fix TLS handshake failure with TLS 1.3 Daniel P. Berrangé
2018-07-24 15:30 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718093815.8104-1-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).