Re: [Qemu-devel] [PATCH] monitor: print message when using 'help' with an unknown command

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Markus Armbruster (armbru@redhat.com) wrote:
> You neglected to cc: maintainers.  Cc'ing them increases the odds your
> patch will be noticed and picked up.  You can use
> scripts/get_maintainer.pl to find maintainers.  You don't have to do
> anything for this patch; it got noticed anyway.
> 
> David, this is yours :)

Thanks!

Dave

> Collin Walling <walling@linux.ibm.com> writes:
> 
> > When typing 'help' followed by an unknown command, QEMU will
> > not print anything to the command line to let the user know
> > they typed a bad command. Let's fix this by printing a message
> > to the monitor when this happens. For example:
> >
> >     (qemu) help xyz
> >     unknown command: 'xyz'
> >
> > Reported-by: Stefan Zimmermann <stzi@linux.ibm.com>
> > Signed-off-by: Collin Walling <walling@linux.ibm.com>
> > ---
> >  monitor.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index 7af1f18..7942f9f 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -1034,9 +1034,12 @@ static void help_cmd_dump(Monitor *mon, const mon_cmd_t *cmds,
> >              } else {
> >                  help_cmd_dump_one(mon, cmd, args, arg_index);
> >              }
> > -            break;
> > +            return;
> >          }
> >      }
> > +
> > +    /* Entry not found */
> > +    monitor_printf(mon, "unknown command: '%s'\n", args[arg_index]);
> >  }
> >  
> >  static void help_cmd(Monitor *mon, const char *name)
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK