From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgELN-0004bF-BQ for qemu-devel@nongnu.org; Thu, 19 Jul 2018 15:12:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgELJ-0003iD-UL for qemu-devel@nongnu.org; Thu, 19 Jul 2018 15:12:05 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:41908 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fgELJ-0003i9-OO for qemu-devel@nongnu.org; Thu, 19 Jul 2018 15:12:01 -0400 Date: Thu, 19 Jul 2018 20:11:58 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180719191158.GC2462@work-vm> References: <1532012617-16777-1-git-send-email-walling@linux.ibm.com> <87sh4f191h.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sh4f191h.fsf@dusky.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] monitor: print message when using 'help' with an unknown command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Collin Walling , qemu-devel@nongnu.org * Markus Armbruster (armbru@redhat.com) wrote: > You neglected to cc: maintainers. Cc'ing them increases the odds your > patch will be noticed and picked up. You can use > scripts/get_maintainer.pl to find maintainers. You don't have to do > anything for this patch; it got noticed anyway. > > David, this is yours :) Thanks! Dave > Collin Walling writes: > > > When typing 'help' followed by an unknown command, QEMU will > > not print anything to the command line to let the user know > > they typed a bad command. Let's fix this by printing a message > > to the monitor when this happens. For example: > > > > (qemu) help xyz > > unknown command: 'xyz' > > > > Reported-by: Stefan Zimmermann > > Signed-off-by: Collin Walling > > --- > > monitor.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/monitor.c b/monitor.c > > index 7af1f18..7942f9f 100644 > > --- a/monitor.c > > +++ b/monitor.c > > @@ -1034,9 +1034,12 @@ static void help_cmd_dump(Monitor *mon, const mon_cmd_t *cmds, > > } else { > > help_cmd_dump_one(mon, cmd, args, arg_index); > > } > > - break; > > + return; > > } > > } > > + > > + /* Entry not found */ > > + monitor_printf(mon, "unknown command: '%s'\n", args[arg_index]); > > } > > > > static void help_cmd(Monitor *mon, const char *name) -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK