From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 5/5] dev-mtp: rename x-root to rootdir
Date: Fri, 20 Jul 2018 17:40:20 -0400 [thread overview]
Message-ID: <20180720214020.22897-6-bsd@redhat.com> (raw)
In-Reply-To: <20180720214020.22897-1-bsd@redhat.com>
x-root was renamed as such owing to the experimental nature of the
property; the underlying filesystem semantics were undecided
Signed-off-by: Bandan Das <bsd@redhat.com>
---
hw/usb/dev-mtp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c
index 2e3ea58da6..3fdc4b0da1 100644
--- a/hw/usb/dev-mtp.c
+++ b/hw/usb/dev-mtp.c
@@ -2018,7 +2018,7 @@ static void usb_mtp_realize(USBDevice *dev, Error **errp)
QTAILQ_INIT(&s->objects);
if (s->desc == NULL) {
if (s->root == NULL) {
- error_setg(errp, "usb-mtp: x-root property must be configured");
+ error_setg(errp, "usb-mtp: rootdir property must be configured");
return;
}
s->desc = strrchr(s->root, '/');
@@ -2047,7 +2047,7 @@ static const VMStateDescription vmstate_usb_mtp = {
};
static Property mtp_properties[] = {
- DEFINE_PROP_STRING("x-root", MTPState, root),
+ DEFINE_PROP_STRING("rootdir", MTPState, root),
DEFINE_PROP_STRING("desc", MTPState, desc),
DEFINE_PROP_BOOL("readonly", MTPState, readonly, true),
DEFINE_PROP_END_OF_LIST(),
--
2.14.4
prev parent reply other threads:[~2018-07-20 21:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 21:40 [Qemu-devel] [PATCH 0/5] usb-mtp write fixes Bandan Das
2018-07-20 21:40 ` [Qemu-devel] [PATCH 1/5] dev-mtp: add support for canceling transaction Bandan Das
2018-07-20 21:40 ` [Qemu-devel] [PATCH 2/5] dev-mtp: fix buffer allocation for writing file contents Bandan Das
2018-07-20 21:40 ` [Qemu-devel] [PATCH 3/5] dev-mtp: retry write for incomplete transfers Bandan Das
2018-08-07 13:28 ` Gerd Hoffmann
2018-08-07 18:15 ` Bandan Das
2018-10-19 9:48 ` Thomas Huth
2018-07-20 21:40 ` [Qemu-devel] [PATCH 4/5] dev-mtp: Add support for > 4GB file transfers Bandan Das
2018-07-20 21:40 ` Bandan Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720214020.22897-6-bsd@redhat.com \
--to=bsd@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).