From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhbJC-0000rE-Ob for qemu-devel@nongnu.org; Mon, 23 Jul 2018 09:55:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhbJB-0002Dz-IZ for qemu-devel@nongnu.org; Mon, 23 Jul 2018 09:55:30 -0400 Date: Mon, 23 Jul 2018 14:55:19 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180723135519.GI3397@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180713071033.15938-1-kwolf@redhat.com> <20180723135345.GF8817@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180723135345.GF8817@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Use host_device instead of file in 149 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: John Snow , qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com On Mon, Jul 23, 2018 at 03:53:45PM +0200, Kevin Wolf wrote: > Am 13.07.2018 um 20:12 hat John Snow geschrieben: > > > > > > On 07/13/2018 03:10 AM, Kevin Wolf wrote: > > > The test case uses block devices with driver=file, which causes the test > > > to fail after commit 230ff73904 added a deprecation warning for this. > > > Fix the test case to use driver=host_device and update the reference > > > output accordingly. > > > > > > Signed-off-by: Kevin Wolf > > > > 149 [not run] requires password-less sudo access: sudo: a > > password is required > > > > Ah, this one hides from regression scripts quite well... > > > > This test fails both before and after this patch for me, with > > > > +Traceback (most recent call last): > > + File "149", line 525, in > > + test_once(config, qemu_img=False) > > + File "149", line 336, in test_once > > + cryptsetup_open(config) > > + File "149", line 200, in cryptsetup_open > > + cryptsetup(args, password) > > + File "149", line 124, in cryptsetup > > + raise Exception(msg) > > +Exception: Device qiotest-145-twofish-128-xts-plain64-sha1 already exists. > > +Command failed with code 17: File exists > > > > Am I missing some prerequisite, maybe? > > Hm, sounds a bit like a failed first attempt that didn't clean up behind > itself properly? Just guessing though. Yeah, sounds like it failed badly enough that cleanup broke. Can probably fix it by either rebooting, or the more nuanced: cryptsetup luksClose qiotest-145-twofish-128-xts-plain64-sha1 Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|