From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhjDf-00026R-Rd for qemu-devel@nongnu.org; Mon, 23 Jul 2018 18:22:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhjDe-0007vs-TT for qemu-devel@nongnu.org; Mon, 23 Jul 2018 18:22:19 -0400 From: John Snow Date: Mon, 23 Jul 2018 18:22:03 -0400 Message-Id: <20180723222210.11077-1-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH for-3.0 0/7] fix persistent bitmaps migration logic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: Juan Quintela , qemu-stable@nongnu.org, "Dr. David Alan Gilbert" , John Snow , Fam Zheng , Kevin Wolf , Stefan Hajnoczi , eblake@redhat.com, Max Reitz This is an updated version of Vladimir's proposal for fixing the handling around migration and persistent dirty bitmaps. Patches 1, 4, 6, and 7 update the testing for this feature. Patch 2 touches up an error message. Patch 3 removes dead code. Patch 5 contains the real fix. v2: - Add a new patch 4 as a prerequisite for what's now patch 5 - Rework the fix to be (hopefully) cleaner, see patch 5 notes - Adjust error message in patch 2 (Eric) - Adjust test logic slightly (patches 6, 7) to deal with changes in patch 5. John Snow (2): iotests: 169: actually test block migration dirty-bitmaps: clean-up bitmaps loading and migration logic Vladimir Sementsov-Ogievskiy (5): iotests: 169: drop deprecated 'autoload' parameter block/qcow2: improve error message in qcow2_inactivate block/qcow2: drop dirty_bitmaps_loaded state variable iotests: improve 169 iotests: 169: add cases for source vm resuming block.c | 4 --- block/dirty-bitmap.c | 20 ------------ block/qcow2-bitmap.c | 16 +++++++++ block/qcow2.c | 26 ++++----------- block/qcow2.h | 1 - include/block/dirty-bitmap.h | 2 +- migration/block-dirty-bitmap.c | 11 ++++--- tests/qemu-iotests/169 | 74 ++++++++++++++++++++++++++++++++++++++++-- tests/qemu-iotests/169.out | 4 +-- 9 files changed, 103 insertions(+), 55 deletions(-) -- 2.14.4