qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Fam Zheng" <famz@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: [Qemu-devel] [PULL 10/17] docker: add expansion for docker-test-FOO to Makefile.include
Date: Tue, 24 Jul 2018 11:51:02 +0100	[thread overview]
Message-ID: <20180724105109.8392-11-alex.bennee@linaro.org> (raw)
In-Reply-To: <20180724105109.8392-1-alex.bennee@linaro.org>

This allows us to run a particular test on all docker images. For
example:

  make docker-test-unit

Will run the unit tests on every supported image. At the same time
rename docker-test to docker-all-tests to be clearer.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 09fb7db7fa..8fbb076396 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -148,7 +148,8 @@ $(foreach i,$(filter-out $(DOCKER_PARTIAL_IMAGES),$(DOCKER_IMAGES) $(DOCKER_DEPR
 		$(eval docker-$t@$i: docker-image-$i docker-run-$t@$i) \
 	) \
 	$(foreach t,$(DOCKER_TESTS), \
-		$(eval docker-test: docker-$t@$i) \
+		$(eval docker-all-tests: docker-$t@$i) \
+		$(eval docker-$t: docker-$t@$i) \
 	) \
 )
 
@@ -158,7 +159,8 @@ docker:
 	@echo 'Available targets:'
 	@echo
 	@echo '    docker:              Print this help.'
-	@echo '    docker-test:         Run all image/test combinations.'
+	@echo '    docker-all-tests:    Run all image/test combinations.'
+	@echo '    docker-TEST:         Run TEST on all image combinations.'
 	@echo '    docker-clean:        Kill and remove residual docker testing containers.'
 	@echo '    docker-TEST@IMAGE:   Run "TEST" in container "IMAGE".'
 	@echo '                         Note: "TEST" is one of the listed test name,'
-- 
2.17.1

  parent reply	other threads:[~2018-07-24 10:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 10:50 [Qemu-devel] [PULL for 3.0 00/17] docker fixes and tcg test tweak Alex Bennée
2018-07-24 10:50 ` [Qemu-devel] [PULL 01/17] tests/.gitignore: don't ignore docker tests Alex Bennée
2018-07-24 10:50 ` [Qemu-devel] [PULL 02/17] docker: base debian-tricore on qemu:debian9 Alex Bennée
2018-07-24 10:50 ` [Qemu-devel] [PULL 03/17] docker: par down QEMU_CONFIGURE_OPTS in debian-tricore-cross Alex Bennée
2018-07-24 10:50 ` [Qemu-devel] [PULL 04/17] docker: fail more gracefully on docker.py check Alex Bennée
2018-07-24 10:50 ` [Qemu-devel] [PULL 05/17] docker: split configure_qemu from build_qemu Alex Bennée
2018-07-24 10:50 ` [Qemu-devel] [PULL 06/17] docker: move make check into check_qemu helper Alex Bennée
2020-06-19 10:32   ` Peter Maydell
2018-07-24 10:50 ` [Qemu-devel] [PULL 07/17] docker: gracefully skip check_qemu Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 08/17] docker: Makefile.include don't include partial images Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 09/17] docker: add test-unit runner Alex Bennée
2018-07-24 10:51 ` Alex Bennée [this message]
2018-07-24 10:51 ` [Qemu-devel] [PULL 11/17] docker: drop QEMU_TARGET check, fallback in EXECUTABLE not set Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 12/17] docker: report hint when docker.py check fails Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 13/17] docker: Update debootstrap script after Debian migration from Alioth to Salsa Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 14/17] docker: add commentary to debian-bootstrap.docker Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 15/17] docker: ignore distro versioning of debootstrap Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 16/17] docker: perform basic binfmt_misc validation in docker.py Alex Bennée
2018-07-24 10:51 ` [Qemu-devel] [PULL 17/17] tests/tcg: remove runcom test Alex Bennée
2018-07-24 14:17 ` [Qemu-devel] [PULL for 3.0 00/17] docker fixes and tcg test tweak Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724105109.8392-11-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).