From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH RFC for-3.0-rc3 0/3] qemu-img: Disable copy offloading by default
Date: Fri, 27 Jul 2018 11:33:59 +0800 [thread overview]
Message-ID: <20180727033402.13513-1-famz@redhat.com> (raw)
Kevin pointed out that both glibc and kernel provides a slow fallback of
copy_file_range which hurts thin provisioning. This is particularly true for
thin LVs, because host_device driver cannot get allocation info from the
volume, and copy_file_range is called on every sectors, making the dst fully
allocated.
NFS mount points also doesn't support SEEK_DATA well, so the allocation
information is unknown to QEMU.
That leaves only iscsi:// which seems to do what we want so far, but it is a
smaller use case.
Add an option to qemu-img convert, "-C", to enable (attempting) copy offloading
explicitly. And mark it incompatible with "-S" and "-c".
Fam Zheng (3):
Revert "qemu-img: Document copy offloading implications with -S and
-c"
qemu-img: Add -C option for convert with copy offloading
iotests: Add test for 'qemu-img convert -C' compatibility
qemu-img-cmds.hx | 2 +-
qemu-img.c | 21 +++++++++++++++++----
qemu-img.texi | 14 +++++++++-----
tests/qemu-iotests/082 | 8 ++++++++
tests/qemu-iotests/082.out | 11 +++++++++++
5 files changed, 46 insertions(+), 10 deletions(-)
--
2.17.1
next reply other threads:[~2018-07-27 3:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 3:33 Fam Zheng [this message]
2018-07-27 3:34 ` [Qemu-devel] [PATCH RFC for-3.0-rc3 1/3] Revert "qemu-img: Document copy offloading implications with -S and -c" Fam Zheng
2018-07-27 3:34 ` [Qemu-devel] [PATCH RFC for-3.0-rc3 2/3] qemu-img: Add -C option for convert with copy offloading Fam Zheng
2018-07-27 3:34 ` [Qemu-devel] [PATCH RFC for-3.0-rc3 3/3] iotests: Add test for 'qemu-img convert -C' compatibility Fam Zheng
2018-07-27 10:29 ` [Qemu-devel] [PATCH RFC for-3.0-rc3 0/3] qemu-img: Disable copy offloading by default Kevin Wolf
2018-07-27 12:14 ` Fam Zheng
2018-07-27 13:40 ` [Qemu-devel] [Qemu-block] " Nir Soffer
2018-07-27 14:52 ` [Qemu-devel] " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727033402.13513-1-famz@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).