qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] travis: Test out-of-tree builds
Date: Fri, 27 Jul 2018 17:10:30 +0800	[thread overview]
Message-ID: <20180727091030.GE19416@lemon.usersys.redhat.com> (raw)
In-Reply-To: <20180621122638.12113-1-f4bug@amsat.org>

On Thu, 06/21 09:26, Philippe Mathieu-Daudé wrote:
> Force one config to build 'out-of-tree' (object files and executables
> are created in a tree outside the project source code).
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> I noticed various out-of-tree issue in the last 2 merge windows.
> 
> Pseudo-randomly picked a build from the matrix which covers system + user.
> 
>  .travis.yml | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index fabfe9ec34..02e096f6a9 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -50,6 +50,8 @@ notifications:
>      on_failure: always
>  env:
>    global:
> +    - SRC_DIR="."
> +    - BUILD_DIR="."
>      - TEST_CMD="make check"
>      - MAKEFLAGS="-j3"
>    matrix:
> @@ -69,11 +71,15 @@ before_install:
>    - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ
>    - git submodule update --init --recursive
>  before_script:
> -  - ./configure ${CONFIG} || { cat config.log && exit 1; }
> +  - mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
> +  - ${SRC_DIR}/configure ${CONFIG} || { cat config.log && exit 1; }
>  script:
>    - make ${MAKEFLAGS} && ${TEST_CMD}
>  matrix:
>    include:
> +    # Test out-of-tree builds
> +    - env: CONFIG="--enable-debug --enable-debug-tcg"
> +           BUILD_DIR="out-of-tree/build/dir" SRC_DIR="../../.."

Is a three-level nesting really necessary? I think a simple './build' dir should
do.

>      # Test with Clang for compile portability (Travis uses clang-5.0)
>      - env: CONFIG="--disable-system"
>        compiler: clang
> -- 
> 2.18.0.rc2
> 

Fam

  reply	other threads:[~2018-07-27  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 12:26 [Qemu-devel] [RFC PATCH] travis: Test out-of-tree builds Philippe Mathieu-Daudé
2018-07-27  9:10 ` Fam Zheng [this message]
2018-07-27  9:14 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727091030.GE19416@lemon.usersys.redhat.com \
    --to=famz@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).