Re: [Qemu-devel] [PATCH] macio/pmu: Fix missing vmsd terminator

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Mark Cave-Ayland (mark.cave-ayland@ilande.co.uk) wrote:
> On 27/07/18 13:31, Dr. David Alan Gilbert (git) wrote:
> 
> > From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> > 
> > Fix missing terminator in VMStateDescription
> > 
> > Fixes: d811d61fbc6ca5f2be2185fd7cfa916e7ba613ce
> > Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > ---
> >   hw/misc/macio/pmu.c | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/hw/misc/macio/pmu.c b/hw/misc/macio/pmu.c
> > index e246b0fd41..27dfaf8a74 100644
> > --- a/hw/misc/macio/pmu.c
> > +++ b/hw/misc/macio/pmu.c
> > @@ -686,6 +686,7 @@ static const VMStateDescription vmstate_pmu_adb = {
> >           VMSTATE_TIMER_PTR(adb_poll_timer, PMUState),
> >           VMSTATE_UINT8(adb_reply_size, PMUState),
> >           VMSTATE_BUFFER(adb_reply, PMUState),
> > +        VMSTATE_END_OF_LIST()
> >       }
> >   };
> 
> Gah, yes indeed it certainly looks like I missed this whilst working on the
> PMU code :(
> 
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> 
> Just out of interest does a savevm/loadvm migration still succeed once this
> has been added?

Have you got a suggested command line to test it with?

Dave

> 
> ATB,
> 
> Mark.
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK