From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fj33H-0000vh-69 for qemu-devel@nongnu.org; Fri, 27 Jul 2018 09:45:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fj33C-0003O1-6V for qemu-devel@nongnu.org; Fri, 27 Jul 2018 09:45:03 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:53618 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fj33C-0003Np-0p for qemu-devel@nongnu.org; Fri, 27 Jul 2018 09:44:58 -0400 Date: Fri, 27 Jul 2018 14:44:54 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180727134453.GB2498@work-vm> References: <20180727123112.13707-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] macio/pmu: Fix missing vmsd terminator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Cave-Ayland Cc: qemu-devel@nongnu.org, agraf@suse.de, lvivier@redhat.com * Mark Cave-Ayland (mark.cave-ayland@ilande.co.uk) wrote: > On 27/07/18 13:31, Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > Fix missing terminator in VMStateDescription > > > > Fixes: d811d61fbc6ca5f2be2185fd7cfa916e7ba613ce > > Signed-off-by: Dr. David Alan Gilbert > > --- > > hw/misc/macio/pmu.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/hw/misc/macio/pmu.c b/hw/misc/macio/pmu.c > > index e246b0fd41..27dfaf8a74 100644 > > --- a/hw/misc/macio/pmu.c > > +++ b/hw/misc/macio/pmu.c > > @@ -686,6 +686,7 @@ static const VMStateDescription vmstate_pmu_adb = { > > VMSTATE_TIMER_PTR(adb_poll_timer, PMUState), > > VMSTATE_UINT8(adb_reply_size, PMUState), > > VMSTATE_BUFFER(adb_reply, PMUState), > > + VMSTATE_END_OF_LIST() > > } > > }; > > Gah, yes indeed it certainly looks like I missed this whilst working on the > PMU code :( > > Reviewed-by: Mark Cave-Ayland > > Just out of interest does a savevm/loadvm migration still succeed once this > has been added? Have you got a suggested command line to test it with? Dave > > ATB, > > Mark. -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK