From: Leonid Bloch <lbloch@janustech.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, Eric Blake <eblake@redhat.com>,
Leonid Bloch <lbloch@janustech.com>
Subject: [Qemu-devel] [PATCH 6/6] qcow2: Resize the cache upon image resizing
Date: Mon, 30 Jul 2018 00:27:44 +0300 [thread overview]
Message-ID: <20180729212744.23709-7-lbloch@janustech.com> (raw)
In-Reply-To: <20180729212744.23709-1-lbloch@janustech.com>
The caches are now recalculated upon image resizing. This is done
because the new default behavior of assigning a sufficient L2 cache to
cover the entire image implies that the cache will still be sufficient
after image resizing. To put a limit on the cache, the options
cache-size and l2-cache-size can be used.
Signed-off-by: Leonid Bloch <lbloch@janustech.com>
---
block/qcow2.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 74f2cb10a4..06fac1bb8c 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -3656,6 +3656,12 @@ static int coroutine_fn qcow2_co_truncate(BlockDriverState *bs, int64_t offset,
}
s->l1_vm_state_index = new_l1_size;
+ /* Update cache sizes */
+ QDict *options = qdict_clone_shallow(bs->options);
+ ret = qcow2_update_options(bs, options, s->flags, errp);
+ if (ret < 0) {
+ goto fail;
+ }
ret = 0;
fail:
qemu_co_mutex_unlock(&s->lock);
--
2.17.1
next prev parent reply other threads:[~2018-07-29 21:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 21:27 [Qemu-devel] [PATCH 0/6] qcow2: Make the L2 cache cover the whole image by default Leonid Bloch
2018-07-29 21:27 ` [Qemu-devel] [PATCH 1/6 for-3.0] Update .gitignore Leonid Bloch
2018-07-30 15:40 ` Eric Blake
2018-07-30 15:43 ` Eric Blake
2018-07-29 21:27 ` [Qemu-devel] [PATCH 2/6 for-3.0] qcow2: A grammar fix in conflicting cache sizing error message Leonid Bloch
2018-07-29 21:27 ` [Qemu-devel] [PATCH 3/6 for-3.0] qcow2: Options' documentation fixes Leonid Bloch
2018-08-03 11:27 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-08-04 11:52 ` Leonid Bloch
2018-07-29 21:27 ` [Qemu-devel] [PATCH 4/6] qcow2: Update total_sectors when resizing the image Leonid Bloch
2018-07-30 9:43 ` Kevin Wolf
2018-07-30 11:41 ` Leonid Bloch
2018-07-30 12:28 ` Kevin Wolf
2018-08-03 11:56 ` [Qemu-devel] [Qemu-block] " Alberto Garcia
2018-07-29 21:27 ` [Qemu-devel] [PATCH 5/6] qcow2: Make the default L2 cache sufficient to cover the entire image Leonid Bloch
2018-07-29 21:27 ` Leonid Bloch [this message]
2018-08-03 12:42 ` [Qemu-devel] [Qemu-block] [PATCH 6/6] qcow2: Resize the cache upon image resizing Alberto Garcia
2018-08-04 11:53 ` Leonid Bloch
2018-07-30 10:55 ` [Qemu-devel] [PATCH 0/6] qcow2: Make the L2 cache cover the whole image by default Kevin Wolf
2018-07-30 12:13 ` Leonid Bloch
2018-07-30 12:44 ` Kevin Wolf
2018-08-03 13:37 ` Alberto Garcia
2018-08-03 14:55 ` Kevin Wolf
2018-08-06 7:47 ` Alberto Garcia
2018-08-06 10:45 ` Kevin Wolf
2018-08-06 11:07 ` Alberto Garcia
2018-08-06 11:30 ` Kevin Wolf
2018-08-06 11:41 ` Alberto Garcia
2018-08-03 7:38 ` Kevin Wolf
2018-08-04 11:48 ` Leonid Bloch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180729212744.23709-7-lbloch@janustech.com \
--to=lbloch@janustech.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).