qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: yuchenlin@synology.com
To: qemu-devel@nongnu.org
Cc: sw@weilnetz.de, qemu-block@nongnu.org,
	yuchenlin <yuchenlin@synology.com>
Subject: [Qemu-devel] [PATCH 1/2] vdi: remove CONFIG_VDI_WRITE
Date: Mon, 30 Jul 2018 10:47:00 +0800	[thread overview]
Message-ID: <20180730024701.7613-2-yuchenlin@synology.com> (raw)
In-Reply-To: <20180730024701.7613-1-yuchenlin@synology.com>

From: yuchenlin <yuchenlin@synology.com>

The CONFIG_VDI_WRITE is here when the first time vdi is added.
But there is no reason to leave an always on and cannot configure option
in the code-side.

Signed-off-by: yuchenlin <yuchenlin@synology.com>
---
 block/vdi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/block/vdi.c b/block/vdi.c
index 6555cffb88..12f92e7891 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -70,9 +70,6 @@
 /* Enable debug messages. */
 //~ #define CONFIG_VDI_DEBUG
 
-/* Support write operations on VDI images. */
-#define CONFIG_VDI_WRITE
-
 /* Support non-standard block (cluster) size. This is untested.
  * Maybe it will be needed for very large images.
  */
@@ -1016,9 +1013,7 @@ static BlockDriver bdrv_vdi = {
     .bdrv_make_empty = vdi_make_empty,
 
     .bdrv_co_preadv     = vdi_co_preadv,
-#if defined(CONFIG_VDI_WRITE)
     .bdrv_co_pwritev    = vdi_co_pwritev,
-#endif
 
     .bdrv_get_info = vdi_get_info,
 
-- 
2.17.0

  reply	other threads:[~2018-07-30  2:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30  2:46 [Qemu-devel] [PATCH 0/2] Refine some vdi code yuchenlin
2018-07-30  2:47 ` yuchenlin [this message]
2018-07-30  2:47 ` [Qemu-devel] [PATCH 2/2] vdi: refine code for vdi_open yuchenlin
2018-07-30  7:12 ` [Qemu-devel] [PATCH 0/2] Refine some vdi code Stefan Weil
2018-07-30  7:49   ` yuchenlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730024701.7613-2-yuchenlin@synology.com \
    --to=yuchenlin@synology.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).