qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements
Date: Mon, 30 Jul 2018 09:01:37 -0600	[thread overview]
Message-ID: <20180730090137.15917879@t450s.home> (raw)
In-Reply-To: <20180730174601-mutt-send-email-mst@kernel.org>

On Mon, 30 Jul 2018 17:51:28 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Jul 30, 2018 at 08:39:39AM -0600, Alex Williamson wrote:
> > This is more
> > compatible with the IOMMU mappings,  
> 
> Precisely. These are at page granularity.

(This/these being memory API mappings for context)

SubRegions are not page granule, the entire previous SubRegion needs to
be unmapped and any remaining SubRegions re-mapped.
 
> > but I don't think it can be done
> > atomically with respect to inflight DMA of a physical device where we
> > cannot halt the device without interfering with its state.  
> 
> Guests never add pages to the balloon if they are under DMA,
> so that's fine - there's never an in-flight DMA, if
> there is guest is buggy and it's ok to crash it.

It's not the ballooned page that I'm trying to note, it's the entire
remainder of the SubRegion which needs to be unmapped to remove that
one page.  It's more compatible from an IOMMU perspective in that we're
only unmapping with the same granularity with which we mapped, but it's
incompatible with inflight DMA as we have no idea what DMA targets may
reside within the remainder of that mapping while it's temporarily
unmapped.  Thanks,

Alex

  reply	other threads:[~2018-07-30 15:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 22:47 [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements Alex Williamson
2018-07-17 22:47 ` [Qemu-devel] [RFC PATCH 1/3] balloon: Allow nested inhibits Alex Williamson
2018-07-18  6:40   ` Peter Xu
2018-07-18 16:37     ` Alex Williamson
2018-07-19  4:45       ` Peter Xu
2018-07-17 22:47 ` [Qemu-devel] [RFC PATCH 2/3] kvm: Use inhibit to prevent ballooning without synchronous mmu Alex Williamson
2018-07-17 22:47 ` [Qemu-devel] [RFC PATCH 3/3] vfio: Inhibit ballooning Alex Williamson
2018-07-18  6:48 ` [Qemu-devel] [RFC PATCH 0/3] Balloon inhibit enhancements Peter Xu
2018-07-18  9:36   ` Cornelia Huck
2018-07-19  4:49     ` Peter Xu
2018-07-19  8:42       ` Cornelia Huck
2018-07-19  9:30         ` Peter Xu
2018-07-19 15:31       ` Alex Williamson
2018-07-18 16:31   ` Alex Williamson
2018-07-19  5:40     ` Peter Xu
2018-07-19 15:01       ` Alex Williamson
2018-07-20  2:56         ` Peter Xu
2018-07-30 13:34 ` Michael S. Tsirkin
2018-07-30 13:54   ` David Hildenbrand
2018-07-30 13:59     ` Michael S. Tsirkin
2018-07-30 14:46       ` David Hildenbrand
2018-07-30 14:58         ` Michael S. Tsirkin
2018-07-30 15:05           ` David Hildenbrand
2018-07-30 14:39   ` Alex Williamson
2018-07-30 14:51     ` Michael S. Tsirkin
2018-07-30 15:01       ` Alex Williamson [this message]
2018-07-30 15:49         ` Michael S. Tsirkin
2018-07-30 16:42           ` Alex Williamson
2018-07-30 17:35             ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730090137.15917879@t450s.home \
    --to=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).