From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fk4i8-0001vm-T5 for qemu-devel@nongnu.org; Mon, 30 Jul 2018 05:43:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fk4i8-0002jP-6N for qemu-devel@nongnu.org; Mon, 30 Jul 2018 05:43:28 -0400 Date: Mon, 30 Jul 2018 11:43:20 +0200 From: Kevin Wolf Message-ID: <20180730094320.GB3775@localhost.localdomain> References: <20180729212744.23709-1-lbloch@janustech.com> <20180729212744.23709-5-lbloch@janustech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180729212744.23709-5-lbloch@janustech.com> Subject: Re: [Qemu-devel] [PATCH 4/6] qcow2: Update total_sectors when resizing the image List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Bloch Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , Eric Blake Am 29.07.2018 um 23:27 hat Leonid Bloch geschrieben: > Signed-off-by: Leonid Bloch > --- > block/qcow2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block/qcow2.c b/block/qcow2.c > index ec9e6238a0..223d351e40 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3646,6 +3646,8 @@ static int coroutine_fn qcow2_co_truncate(BlockDriverState *bs, int64_t offset, > } > } > > + bs->total_sectors = offset / 512; > + > /* write updated header.size */ > offset = cpu_to_be64(offset); > ret = bdrv_pwrite_sync(bs->file, offsetof(QCowHeader, size), This shouldn't be necessary, bdrv_co_truncate() already updates bs->total_sectors after calling the block driver. If this is needed by one of the following patches, we need a comment that explains why this seemingly superfluous assignment is actually necessary. Also, 512 should be BDRV_SECTOR_SIZE. Kevin